Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first_try #646

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ venv/
.pytest_cache/
**__pycache__/
*.pyc
app/db.sqlite3
app/db.sqlite3
**db.sqlite3
42 changes: 29 additions & 13 deletions cinema/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def __str__(self):
return self.first_name + " " + self.last_name

@property
def full_name(self):
def full_name(self) -> str:
return f"{self.first_name} {self.last_name}"


Expand Down Expand Up @@ -84,24 +84,40 @@ class Ticket(models.Model):
row = models.IntegerField()
seat = models.IntegerField()

def clean(self):
for ticket_attr_value, ticket_attr_name, cinema_hall_attr_name in [
(self.row, "row", "rows"),
(self.seat, "seat", "seats_in_row"),
@staticmethod
def validate_seats(
seat: int,
row: int,
movie_session: MovieSession,
error_to_raise
) -> None:
for ticket_atr_value, ticket_attr_name, cinema_hall_attr_name in [
(seat, "seat", "seats_in_row"),
(row, "row", "rows")
]:
count_attrs = getattr(
self.movie_session.cinema_hall, cinema_hall_attr_name
movie_session.cinema_hall,
cinema_hall_attr_name
)
if not (1 <= ticket_attr_value <= count_attrs):
raise ValidationError(
if not (1 <= ticket_atr_value <= count_attrs):
raise error_to_raise(
{
ticket_attr_name: f"{ticket_attr_name} "
f"number must be in available range: "
f"(1, {cinema_hall_attr_name}): "
f"(1, {count_attrs})"
ticket_attr_name:
f"{ticket_attr_name} number must be "
f"in available range: "
f"(1, {cinema_hall_attr_name}): (1, {count_attrs})"
}

)

def clean(self):
Ticket.validate_seats(
self.seat,
self.row,
self.movie_session,
ValidationError
)

def save(
self,
force_insert=False,
Expand All @@ -110,7 +126,7 @@ def save(
update_fields=None,
):
self.full_clean()
super(Ticket, self).save(
return super(Ticket, self).save(
force_insert, force_update, using, update_fields
)

Expand Down
7 changes: 7 additions & 0 deletions cinema/pagination.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
from rest_framework.pagination import PageNumberPagination


class OrderSetPagination(PageNumberPagination):
page_size = 3
page_size_query_param = "page_size"
max_page_size = 5
76 changes: 72 additions & 4 deletions cinema/serializers.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
from django.db import transaction
from rest_framework import serializers

from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession
from cinema.models import (
Genre,
Actor,
CinemaHall,
Movie,
MovieSession,
Ticket,
Order
)


class GenreSerializer(serializers.ModelSerializer):
Expand Down Expand Up @@ -59,6 +68,7 @@ class MovieSessionListSerializer(MovieSessionSerializer):
cinema_hall_capacity = serializers.IntegerField(
source="cinema_hall.capacity", read_only=True
)
tickets_available = serializers.IntegerField(read_only=True)

class Meta:
model = MovieSession
Expand All @@ -68,13 +78,71 @@ class Meta:
"movie_title",
"cinema_hall_name",
"cinema_hall_capacity",
"tickets_available",
)


class TicketSerializer(serializers.ModelSerializer):
class Meta:
model = Ticket
fields = ("id", "row", "seat", "movie_session")

def validate(self, attr: dict) -> dict:
Ticket.validate_seats(
attr["seat"],
attr["row"],
attr["movie_session"],
error_to_raise=serializers.ValidationError(
"This seat is already taken"
),
)
return attr


class TicketSeatsSerializer(TicketSerializer):
class Meta:
model = Ticket
fields = ("row", "seat")


class MovieSessionDetailSerializer(MovieSessionSerializer):
movie = MovieListSerializer(many=False, read_only=True)
cinema_hall = CinemaHallSerializer(many=False, read_only=True)
movie = MovieListSerializer(read_only=True)
cinema_hall = CinemaHallSerializer(read_only=True)
taken_places = TicketSeatsSerializer(
source="tickets",
many=True,
read_only=True
)

def get_taken_places(self, movie_session: MovieSession) -> list:
return [
{"row": ticket.row, "seat": ticket.seat}
for ticket in movie_session.tickets.all()
]

class Meta:
model = MovieSession
fields = ("id", "show_time", "movie", "cinema_hall")
fields = ("id", "show_time", "movie", "cinema_hall", "taken_places")


class TicketListSerializer(TicketSerializer):
movie_session = MovieSessionListSerializer(read_only=True, many=False)


class OrderSerializer(serializers.ModelSerializer):
tickets = TicketSerializer(many=True, allow_empty=False)

class Meta:
model = Order
fields = ("id", "created_at", "tickets")

def create(self, validated_data):
with transaction.atomic():
tickets_data = validated_data.pop("tickets")
order = Order.objects.create(**validated_data)
for ticket_data in tickets_data:
Ticket.objects.create(order=order, **ticket_data)


class OrderListSerializer(OrderSerializer):
tickets = TicketListSerializer(many=True, read_only=True)
2 changes: 2 additions & 0 deletions cinema/urls.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
CinemaHallViewSet,
MovieViewSet,
MovieSessionViewSet,
OrderViewSet,
)

router = routers.DefaultRouter()
Expand All @@ -15,6 +16,7 @@
router.register("cinema_halls", CinemaHallViewSet)
router.register("movies", MovieViewSet)
router.register("movie_sessions", MovieSessionViewSet)
router.register("orders", OrderViewSet)

urlpatterns = [path("", include(router.urls))]

Expand Down
2 changes: 2 additions & 0 deletions cinema/utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
def filter_request_to_int(query_params: str) -> list:
return [int(str_id) for str_id in query_params.split(",")]
79 changes: 78 additions & 1 deletion cinema/views.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
from django.db.models import F, Count
from rest_framework import viewsets

from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession
from cinema.models import Genre, Actor, CinemaHall, Movie, MovieSession, Order
from cinema.pagination import OrderSetPagination
from cinema.utils import filter_request_to_int

from cinema.serializers import (
GenreSerializer,
Expand All @@ -12,6 +15,8 @@
MovieDetailSerializer,
MovieSessionDetailSerializer,
MovieListSerializer,
OrderSerializer,
OrderListSerializer,
)


Expand Down Expand Up @@ -43,6 +48,28 @@ def get_serializer_class(self):

return MovieSerializer

def get_queryset(self):
queryset = super().get_queryset()

if self.action == "list":
queryset = self.queryset.prefetch_related("actors", "genres")

genres = self.request.query_params.get("genres")
actors = self.request.query_params.get("actors")
title = self.request.query_params.get("title")
if genres:
genres = filter_request_to_int(genres)
queryset = queryset.filter(genres__id__in=genres)

if actors:
actors = filter_request_to_int(actors)
queryset = queryset.filter(actors__id__in=actors)

if title:
queryset = queryset.filter(title__icontains=title)

return queryset.distinct()


class MovieSessionViewSet(viewsets.ModelViewSet):
queryset = MovieSession.objects.all()
Expand All @@ -56,3 +83,53 @@ def get_serializer_class(self):
return MovieSessionDetailSerializer

return MovieSessionSerializer

def get_queryset(self):
queryset = super().get_queryset()
if self.action == "list":
queryset = queryset.select_related()
movie = self.request.query_params.get("movie")
date = self.request.query_params.get("date")

if movie:
queryset = queryset.filter(movie_id=movie)

if date:
queryset = queryset.filter(show_time__date=date)

queryset = queryset.annotate(
tickets_available=F("cinema_hall__rows")
* F("cinema_hall__seats_in_row")
- Count("tickets")
)
if self.action == "retrieve":
queryset = queryset.select_related("movie", "cinema_hall")

return queryset


class OrderViewSet(viewsets.ModelViewSet):
queryset = Order.objects.all()
serializer_class = OrderSerializer
pagination_class = OrderSetPagination

def get_queryset(self):
queryset = self.queryset.filter(user=self.request.user)

if self.action in ("list", "retrieve"):
queryset = queryset.prefetch_related(
"tickets__movie_session__movie",
"tickets__movie_session__cinema_hall"
)

return queryset

def get_serializer_class(self):
serializer = self.serializer_class
if self.action in ("list", "retrieve"):
return OrderListSerializer

return serializer

def perform_create(self, serializer):
serializer.save(user=self.request.user)
2 changes: 1 addition & 1 deletion cinema_service/settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@

USE_I18N = True

USE_TZ = False
USE_TZ = True


# Static files (CSS, JavaScript, Images)
Expand Down
Loading