first_try #646
Open
first_try #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OleksiukStepan
approved these changes
Oct 1, 2024
cinema/tests/test_actor_api.py
Outdated
| @@ -14,6 +14,7 @@ def setUp(self): | |||
|
|
|||
| def test_get_actors(self): | |||
| response = self.client.get("/api/cinema/actors/") | |||
| print(response.data) | |||
There was a problem hiding this comment.
Don't forget to delete testing prints
cinema/urls.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| ActorViewSet, | |||
| CinemaHallViewSet, | |||
| MovieViewSet, | |||
| MovieSessionViewSet, | |||
| MovieSessionViewSet, OrderViewSet, | |||
cinema/views.py
Outdated
| @@ -11,7 +14,7 @@ | |||
| MovieSessionListSerializer, | |||
| MovieDetailSerializer, | |||
| MovieSessionDetailSerializer, | |||
| MovieListSerializer, | |||
| MovieListSerializer, OrderSerializer, OrderListSerializer, | |||
oliasymak24
suggested changes
Oct 8, 2024
cinema/tests/test_actor_api.py
Outdated
cinema/serializers.py
Outdated
Comment on lines
86
to
87
| movie = MovieListSerializer(many=False, read_only=True) | ||
| cinema_hall = CinemaHallSerializer(many=False, read_only=True) |
cinema/serializers.py
Outdated
| order = Order.objects.create(**validated_data) | ||
| for ticket_data in tickets_data: | ||
| Ticket.objects.create(order=order, **ticket_data) | ||
| return order |
There was a problem hiding this comment.
In create/update/delete fucntion you don't need return anything
cinema/urls.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| ActorViewSet, | |||
| CinemaHallViewSet, | |||
| MovieViewSet, | |||
| MovieSessionViewSet, | |||
| MovieSessionViewSet, OrderViewSet, | |||
cinema/utils.py
Outdated
| @@ -0,0 +1,2 @@ | |||
| def filter_request_to_int(query_params): | |||
There was a problem hiding this comment.
Annotations, everywhere :) They still exist)
cinema/views.py
Outdated
| @@ -43,6 +46,28 @@ def get_serializer_class(self): | |||
|
|
|||
| return MovieSerializer | |||
|
|
|||
| def get_queryset(self): | |||
| queryset = self.queryset | |||
There was a problem hiding this comment.
call super method instead of accesing this attribute directly
solve N+1 problem
cinema/views.py
Outdated
|
|
||
| if actors: | ||
| actors = filter_request_to_int(actors) | ||
| queryset = queryset.filter(actors__id__in=actors).distinct() |
cinema/views.py
Outdated
| @@ -56,3 +81,53 @@ def get_serializer_class(self): | |||
| return MovieSessionDetailSerializer | |||
|
|
|||
| return MovieSessionSerializer | |||
|
|
|||
| def get_queryset(self): | |||
| queryset = self.queryset | |||
Oleksl888
suggested changes
Oct 11, 2024
cinema/models.py
Outdated
| force_update=False, | ||
| using=None, | ||
| update_fields=None, | ||
| self, |
cinema/serializers.py
Outdated
| cinema_hall = CinemaHallSerializer(many=False, read_only=True) | ||
| movie = MovieListSerializer(read_only=True) | ||
| cinema_hall = CinemaHallSerializer(read_only=True) | ||
| taken_places = serializers.SerializerMethodField() |
There was a problem hiding this comment.
Here better to use nested serializer instead of creating method. Create a serializer that has row and seat fields and pass it here
Oleksl888
reviewed
Oct 17, 2024
db.sqlite3
Outdated
Oleksl888
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.