Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: patch getBuildSettings to allow run ios from cli #8345

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: patch getBuildSettings to allow run ios from cli #8345

merged 1 commit into from
Nov 13, 2024

Conversation

rahimrahman
Copy link
Contributor

Summary

Fix issue so that npm run ios command will work again. Fix suggested from:

react-native-community/cli#2383 (comment)

Ticket Link

Checklist

  • Added or updated unit tests (required for all new features)
  • Has UI changes
  • Includes text changes and localization file updates
  • Have tested against the 5 core themes to ensure consistency between them.
  • Have run E2E tests by adding label E2E iOS tests for PR.

Device Information

This PR was tested on:

Screenshots

Release Note

@mm-cloud-bot mm-cloud-bot added kind/chore Categorizes issue or PR as related to updates that are not production code. release-note labels Nov 13, 2024
@rahimrahman rahimrahman added the Build App for iOS Build the mobile app for iOS label Nov 13, 2024
Willyfrog
Willyfrog approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working on my setup

enahum
enahum approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@enahum enahum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Lets keep in mind that this package has been deprecated starting with rn 0.76

@enahum enahum merged commit a2af0aa into main Nov 13, 2024
28 checks passed
@enahum enahum deleted the chore/getBuildSettings-fix-to-run-ios-from-cli branch November 13, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enahum enahum enahum approved these changes

@Willyfrog Willyfrog Willyfrog approved these changes

@lieut-data lieut-data Awaiting requested review from lieut-data

Assignees
No one assigned
Labels
Build App for iOS Build the mobile app for iOS kind/chore Categorizes issue or PR as related to updates that are not production code. release-note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rahimrahman @Willyfrog @enahum @mm-cloud-bot