Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: patch getBuildSettings to allow run ios from cli #8345

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: patch getBuildSettings to allow run ios from cli #8345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions patches/@react-native-community+cli-platform-apple+13.6.9.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
diff --git a/node_modules/@react-native-community/cli-platform-apple/build/commands/runCommand/getBuildSettings.js b/node_modules/@react-native-community/cli-platform-apple/build/commands/runCommand/getBuildSettings.js
index 147bb53..b7cb80c 100644
--- a/node_modules/@react-native-community/cli-platform-apple/build/commands/runCommand/getBuildSettings.js
+++ b/node_modules/@react-native-community/cli-platform-apple/build/commands/runCommand/getBuildSettings.js
@@ -31,10 +31,16 @@ async function getBuildSettings(xcodeProject, mode, buildOutput, scheme, target)
encoding: 'utf8'
});
const settings = JSON.parse(buildSettings);
+ const fistIndexForAppTarget = Math.max(
+ 0,
+ settings.findIndex(({
+ buildSettings: bs
+ }) => bs.WRAPPER_EXTENSION === 'app')
+ );
const targets = settings.map(({
target: settingsTarget
}) => settingsTarget);
- let selectedTarget = targets[0];
+ let selectedTarget = targets[fistIndexForAppTarget];
if (target) {
if (!targets.includes(target)) {
_cliTools().logger.info(`Target ${_chalk().default.bold(target)} not found for scheme ${_chalk().default.bold(scheme)}, automatically selected target ${_chalk().default.bold(selectedTarget)}`);