feat: Highlight Keywords without notification #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
requested changes
Oct 5, 2023
|
Sure @M-ZubairAhmed , will add few more. |
M-ZubairAhmed
requested changes
Oct 11, 2023
marianunez
requested changes
Oct 16, 2023
There was a problem hiding this comment.
Thanks @yasserfaraazkhan! Base test cases LGTM, could you include the test cases for the upsell scenarios discussed last week?
| 2. In the `Keywords That Get Highlighted (without notifications)` section, type a test phrases and words. Example: `Testing`, `Testing the keyword highlight without notification feature`. | ||
| 3. Press `Tab` or `Comma` and press `Save` button. | ||
| 4. Open any channel, and post the example phrase. | ||
| 5. Verify the Phrase is Highlighted by a yellow background |
There was a problem hiding this comment.
Could we add an additional step to verify that the phrase does not show in the mentions section in the RHS (like the highlight keywords do)
marianunez
reviewed
Oct 20, 2023
| 2. Scroll to `Keywords That Get Highlighted (without notifications)` section. | ||
| 3. Verify that the Setting is disabled and we see `Professional` tag indicating it is available after upgrading the instance to Professional license. | ||
| 4. Click on the Professional tag. | ||
| 5. Verify that a modal with title `Highlighted Keywords without notifications with Mattermost Professional` appears. |
There was a problem hiding this comment.
Hi @marianunez @abhijit-singh ,
will the title contain Upgrade to use .. like in the below example
M-ZubairAhmed
requested changes
Oct 23, 2023
marianunez
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Thanks @yasserfaraazkhan! LGTM - small note of a verification to add below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Development PR: mattermost/mattermost#24050