-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the ability to import filters #86
base: main
Are you sure you want to change the base?
Conversation
b0e13cd
to
a72f0f2
Compare
I like this one a lot. Why is is not merged? |
I think it was just waiting on some outside confirmation. Wanna try it out? :) |
I've been testing out this update, and it works as expected. I successfully tested both single and multiple filters (e.g. jinja2 -f myfilter.myfunction -f ansible.plugins.filter.core.combine test.txt). |
I hope you will merge this, since I really need this feature :) |
Is there any chance to see this PR merged into main branch? It can drastically extend jina2-cli capabilities. I tested this patch and it works fine. For example, we have hostname and want to add ip address in rendered config file, so it can be one simple filter (filters/ip.py): import socket
def get_ip(hostname):
return socket.gethostbyname(hostname) and in template it can be
|
@mattrobenolt any chances to merge this change? |
Fixes #85