Py39 support #5
Py39 support #5
Conversation
An empathic patch, for those poor souls whose CI still run on 3.9
It was already a sub-dependencies on some Python versions. This adds it explicitly to the mypy CI, so we can import `Self` from it.
Does the same as #2, but by importing the "real" `Self` from `typing_extensions`. Does it in a `TYPE_CHECKING` block, so the typing_extensions requirement can be just a typing one, not a runtime one.
|
I saw this practice of not depending on I think there have been some discussions about it, saying it's fine because type checkers vendor On a side note there's no need to explicitly annotate |
|
the import guard is to not affect runtime behaviour, right now installing ape-pie does not pull in typing-extensions and I'd like to keep it that way. IMO typing-extensions is ideally a direct dependency. We only install it in our CI pipeline through the optional dependency group for the type checker itself, run-time it's completely opt-in. |
|
My concern was related to python-poetry/poetry#9251 (comment), but I think both approaches work pretty much the same |
The first commit is for the unlucky souls that still have a CI on py3.9
The latter 2 do the same as #2, but using the implementation that became the std lib one in 3.11
Closes #2