Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Py39 support #5

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Py39 support #5

merged 3 commits into from
Jun 10, 2024

Commits on Jun 5, 2024

  1. ⬇️ Lower Python requirement to 3.9 

    An empathic patch, for those poor souls whose CI still run on 3.9
    @CharString
    CharString committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c5594b9 View commit details
    Browse the repository at this point in the history

  2. ➕ Explicitly depend on typing_extensions 

    It was already a sub-dependencies on some Python versions.
This adds it explicitly to the mypy CI, so we can import `Self` from it.
    @CharString
    CharString committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a3f54e0 View commit details
    Browse the repository at this point in the history

  3. 🏷️ [#2] Type hint APICient.configure_from 

    Does the same as #2, but by importing the "real" `Self` from
`typing_extensions`.

Does it in a `TYPE_CHECKING` block, so the typing_extensions requirement
can be just a typing one, not a runtime one.
    @CharString
    CharString committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    c648bf7 View commit details
    Browse the repository at this point in the history