Use meilisearch prefix for services

[94noni]

Pull Request

What does this PR do?

• Improves "best practices/coding standard" as the « search » prefix is to generic, lets be specific for this bundle

This PR can be merged before #265 (as it will require a major release)

TODO:
Assert that the container has all services and that deprecations are triggered

• https://symfony.com/doc/5.4/bundles/best_practices.html#services
• https://symfony.com/doc/5.4/service_container/alias_private.html#deprecating-service-aliases

---

RFC

I found some inconsistency reading the repo:

• Commands namespace: meili:
• Bundle config: meili_search
• Services: search (this PR)

Will it be nice to define them as meilisearcheverywhere?

[94noni]

@norkunas thx for review, I will fix them ASAP
question: do you have a local project where you can test this PR? I coded but not run any project with it, just to check the depreciation on the profiler to be sure :)

[norkunas]

@norkunas thx for review, I will fix them ASAP question: do you have a local project where you can test this PR? I coded but not run any project with it, just to check the depreciation on the profiler to be sure :)

Currently unavailable to chec this in a project, but I'd suggest to add some tests https://symfony.com/doc/current/components/phpunit_bridge.html#write-assertions-about-deprecations to make sure that deprecations are triggered :)

[94noni]

I will need to rework yes as well as testing the PR code runtime locally it will be easier
But for now no much time so plz be patient

[94noni]

@norkunas thx really for your time checking this PR
I've checked this code on a testing project, container boot great and deprecations are here (tested with bin/console -vvv and some local code)

but I would greatly appreciate a local test as well from project maintainers

cheers

[brunoocasali]

bors merge

[meili-bors]

Build failed:

• integration-tests (PHP 7.4) (Symfony 5.4.*)

[94noni]

i dont understand the fail here :s

[brunoocasali]

bors merge

[meili-bors]

Build failed:

• integration-tests (PHP 8.2) (Symfony 6.2.*)

[brunoocasali]

This seems to be related to something other than your code @94noni 😢

[norkunas]

@brunoocasali removed breaking-change label as this does not break BC

[norkunas]

bors merge

[meili-bors]

Build succeeded:

• Code style
• integration-tests (PHP 7.4) (Symfony 5.4.*)
• integration-tests (PHP 8.0) (Symfony 6.0.*)
• integration-tests (PHP 8.1) (Symfony 6.1.*)
• integration-tests (PHP 8.2) (Symfony 6.2.*)