-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use meilisearch prefix for services #266
Conversation
@norkunas thx for review, I will fix them ASAP |
Currently unavailable to chec this in a project, but I'd suggest to add some tests https://symfony.com/doc/current/components/phpunit_bridge.html#write-assertions-about-deprecations to make sure that deprecations are triggered :) |
I will need to rework yes as well as testing the PR code runtime locally it will be easier |
@norkunas thx really for your time checking this PR but I would greatly appreciate a local test as well from project maintainers cheers |
bors merge |
266: Use meilisearch prefix for services r=brunoocasali a=94noni # Pull Request ## What does this PR do? - Improves "best practices/coding standard" as the « search » prefix is to generic, lets be specific for this bundle This PR can be merged before #265 (as it will require a major release) TODO: Assert that the container has all services and that deprecations are triggered - https://symfony.com/doc/5.4/bundles/best_practices.html#services - https://symfony.com/doc/5.4/service_container/alias_private.html#deprecating-service-aliases --------- # RFC I found some inconsistency reading the repo: - Commands namespace: `meili:` - Bundle config: `meili_search` - Services: `search` (this PR) Will it be nice to define them as `meilisearch`everywhere? Co-authored-by: Antoine Makdessi <[email protected]>
Build failed: |
i dont understand the fail here :s |
bors merge |
266: Use meilisearch prefix for services r=brunoocasali a=94noni # Pull Request ## What does this PR do? - Improves "best practices/coding standard" as the « search » prefix is to generic, lets be specific for this bundle This PR can be merged before #265 (as it will require a major release) TODO: Assert that the container has all services and that deprecations are triggered - https://symfony.com/doc/5.4/bundles/best_practices.html#services - https://symfony.com/doc/5.4/service_container/alias_private.html#deprecating-service-aliases --------- # RFC I found some inconsistency reading the repo: - Commands namespace: `meili:` - Bundle config: `meili_search` - Services: `search` (this PR) Will it be nice to define them as `meilisearch`everywhere? Co-authored-by: Antoine Makdessi <[email protected]>
Build failed: |
This seems to be related to something other than your code @94noni 😢 |
@brunoocasali removed |
bors merge |
Build succeeded:
|
Pull Request
What does this PR do?
This PR can be merged before #265 (as it will require a major release)
TODO:
Assert that the container has all services and that deprecations are triggered
RFC
I found some inconsistency reading the repo:
meili:
meili_search
search
(this PR)Will it be nice to define them as
meilisearch
everywhere?