Upgrade to Symfony v5.4 minimum #265

94noni · 2023-06-16T10:22:05Z

Pull Request

Related issue

Fixes #263 (Symfony part)

What does this PR do?

Upgrade to Symfony v5.4 as LTS minimum (BC with EOL v4.4)
- command definition via https://symfony.com/doc/5.4/console.html#creating-a-command
Add also Symfony v6.3 in the CI process
Leverage Rector to ease and automate upgrade (removed as per comments)

src/Command/MeilisearchClearCommand.php

94noni · 2023-06-20T15:56:59Z

@norkunas should rector be kept (for later usage?)
PR is ready nonetheless

src/Command/MeilisearchImportCommand.php

norkunas · 2023-06-21T03:13:27Z

@norkunas should rector be kept (for later usage?)

@brunoocasali should decide, but in case we need it very rarely if at all, maybe we shouldn't introduce as dev dependency to save some resources

norkunas · 2023-06-21T03:14:07Z

By the way Symfony 6.3 should be added to matrix

94noni · 2023-06-21T08:40:14Z

Oki will do indeed the new 6.3
And remove rector for now as project is small so lets keep it simple

brunoocasali · 2023-06-21T13:33:20Z

@brunoocasali should decide, but in case we need it very rarely if at all, maybe we shouldn't introduce as dev dependency to save some resources

I'm not opposed to keeping it, but my go-to opinion about this is: not to add new dependencies, even dev ones. So if we can remove it let's do it! :)

94noni · 2023-06-25T09:09:57Z

@brunoocasali @norkunas friendly ping, PR ready for reviews :)
cheers

norkunas · 2023-06-26T04:31:53Z

@brunoocasali @norkunas friendly ping, PR ready for reviews :) cheers

lgtm

brunoocasali

bors merge

brunoocasali · 2023-07-03T11:17:57Z

Can you check the CI error @94noni? 😇

94noni · 2023-07-05T10:04:09Z

i will have a look at it indeed, hopefully soon :)

brunoocasali · 2023-07-10T16:59:21Z

Hi @94noni, it is because you never got a PR merged. As soon you merge your first one, the CI will automatically run :) it is just a way to avoid spam (I think so)!

norkunas · 2023-07-11T04:29:34Z

6.1.* fails, I suggest to leave overriding public static function getDefaultName() and public static function getDefaultDescription() so they will work on all versions

94noni · 2023-07-11T09:05:52Z

indeed, with the swap to attribute, but the bundle is not sf6+ so we will need to add those back yes
I will update this PR shortly, hopefully CI will be ok :)

norkunas · 2023-07-11T11:48:10Z

can you try git commit --amend --no-edit && git push -f to retrigger CI? not sure why integration-tests (PHP 8.2) (Symfony 6.2.*) does not run

brunoocasali · 2023-07-13T11:52:46Z

bors try

norkunas · 2023-07-13T11:55:03Z

We should merge #266 before

brunoocasali · 2023-07-13T11:58:19Z

Yeah, I was trying to force this CI action to trigger but had no success, either! Let's fix the conflicts then after approved we can see what is happen.

94noni · 2023-07-29T12:17:00Z

as #266 will hopefully be merged shortly, I will rework on this right after
thx

266: Use meilisearch prefix for services r=brunoocasali a=94noni # Pull Request ## What does this PR do? - Improves "best practices/coding standard" as the « search » prefix is to generic, lets be specific for this bundle This PR can be merged before #265 (as it will require a major release) TODO: Assert that the container has all services and that deprecations are triggered - https://symfony.com/doc/5.4/bundles/best_practices.html#services - https://symfony.com/doc/5.4/service_container/alias_private.html#deprecating-service-aliases --------- # RFC I found some inconsistency reading the repo: - Commands namespace: `meili:` - Bundle config: `meili_search` - Services: `search` (this PR) Will it be nice to define them as `meilisearch`everywhere? Co-authored-by: Antoine Makdessi <[email protected]>

brunoocasali · 2023-08-03T16:59:34Z

I just merged the #266 @94noni thanks a lot for your help :)

94noni · 2023-08-03T17:31:57Z

@brunoocasali seems a failure in the merge, will wait a little bit to restart this
also needed for #275

thx !

266: Use meilisearch prefix for services r=brunoocasali a=94noni # Pull Request ## What does this PR do? - Improves "best practices/coding standard" as the « search » prefix is to generic, lets be specific for this bundle This PR can be merged before #265 (as it will require a major release) TODO: Assert that the container has all services and that deprecations are triggered - https://symfony.com/doc/5.4/bundles/best_practices.html#services - https://symfony.com/doc/5.4/service_container/alias_private.html#deprecating-service-aliases --------- # RFC I found some inconsistency reading the repo: - Commands namespace: `meili:` - Bundle config: `meili_search` - Services: `search` (this PR) Will it be nice to define them as `meilisearch`everywhere? Co-authored-by: Antoine Makdessi <[email protected]>

266: Use meilisearch prefix for services r=norkunas a=94noni # Pull Request ## What does this PR do? - Improves "best practices/coding standard" as the « search » prefix is to generic, lets be specific for this bundle This PR can be merged before #265 (as it will require a major release) TODO: Assert that the container has all services and that deprecations are triggered - https://symfony.com/doc/5.4/bundles/best_practices.html#services - https://symfony.com/doc/5.4/service_container/alias_private.html#deprecating-service-aliases --------- # RFC I found some inconsistency reading the repo: - Commands namespace: `meili:` - Bundle config: `meili_search` - Services: `search` (this PR) Will it be nice to define them as `meilisearch`everywhere? Co-authored-by: Antoine Makdessi <[email protected]> Co-authored-by: Tomas Norkūnas <[email protected]>

brunoocasali · 2023-08-14T17:10:00Z

bors merge

curquiza · 2023-09-13T12:49:51Z

Hello @94noni can you rebase your branch please? 😊
There are git conflicts so we cannot merge

94noni · 2023-09-13T13:21:53Z

@curquiza thx for the ping, I've tried resolving on GitHub.com ui, hope it is good
i will not have time available to finish soon this PR and thus also the following one #275

@norkunas please feel free to continue and proceed with PRs

norkunas · 2023-09-13T13:22:08Z

src/Command/MeilisearchClearCommand.php

+    protected static $defaultName = 'meilisearch:clear|meili:clear';
+    protected static $defaultDescription = 'Clear the index documents';
+
    public static function getDefaultName(): string
    {
-        return 'meilisearch:clear|meili:clear';
+        return self::$defaultName;
    }

    public static function getDefaultDescription(): string
    {
-        return 'Clear the index documents';
+        return self::$defaultDescription;
    }


Revert this, as there is no point to do this at current time. When we'll be able to provide info via attributes we will.
Same in other commands

Chris53897 · 2023-11-01T08:20:09Z

@94noni Thanks for your work. Do you have some time to finish this PR? After that PR is merged, Symfony 7 support will be easier to implement.

94noni · 2023-11-01T09:31:01Z

@Chris53897 not so much sadly at the moment
If anyone wants to take over and finish it i will be more than happy to review etc

94noni · 2023-11-09T18:46:09Z

closing in favor of #301 which takes over
thanks for original reviewers and @Chris53897 for continuing :)

94noni added 2 commits June 16, 2023 12:20

Upgrade to Symfony v5.4 minimum

b130b15

Leverage Rector

68adc25

94noni mentioned this pull request Jun 16, 2023

Use meilisearch prefix for services #266

Merged

norkunas reviewed Jun 19, 2023

View reviewed changes

src/Command/MeilisearchClearCommand.php Outdated Show resolved Hide resolved

Run Rector

5dbe03b

94noni force-pushed the issue-263 branch from c098a16 to 5dbe03b Compare June 20, 2023 15:56

94noni changed the title ~~[WIP] Upgrade to Symfony v5.4 minimum~~ Upgrade to Symfony v5.4 minimum Jun 20, 2023

94noni requested a review from norkunas June 20, 2023 15:57

brunoocasali reviewed Jun 20, 2023

View reviewed changes

src/Command/MeilisearchImportCommand.php Show resolved Hide resolved

94noni changed the title ~~Upgrade to Symfony v5.4 minimum~~ [WIP] Upgrade to Symfony v5.4 minimum Jun 21, 2023

94noni changed the title ~~[WIP] Upgrade to Symfony v5.4 minimum~~ Upgrade to Symfony v5.4 minimum Jun 25, 2023

Leverage new symfony command name and description definition

9cc36be

94noni force-pushed the issue-263 branch from 8e5edd3 to 9cc36be Compare June 25, 2023 09:06

Add Symfony v6.3 to the CI

e0a4fe4

This was referenced Jun 14, 2023

[RFC] bump php to v8+ and Symfony to v5.4+ #263

Closed

Use PHP CS with the PSR standards #260

Open

brunoocasali added the breaking-change The related changes are breaking for the users label Jul 3, 2023

brunoocasali previously approved these changes Jul 3, 2023

View reviewed changes

cs fix

6fa5d64

94noni dismissed brunoocasali’s stale review via 6fa5d64 July 10, 2023 06:13

Merge remote-tracking branch 'origin/main' into issue-263

a66ed0e

norkunas previously approved these changes Jul 10, 2023

View reviewed changes

94noni dismissed norkunas’s stale review via a6ed990 July 11, 2023 10:11

94noni force-pushed the issue-263 branch 2 times, most recently from 8a66f9e to 5f9dd09 Compare July 11, 2023 10:26

Add back method until going full attributes

03afde9

94noni force-pushed the issue-263 branch from 5f9dd09 to 03afde9 Compare July 11, 2023 13:53

Merge branch 'main' into issue-263

ce38231

norkunas reviewed Sep 13, 2023

View reviewed changes

Chris53897 mentioned this pull request Nov 3, 2023

Drop support of symfony 4 #301

Merged

2 tasks

94noni closed this Nov 9, 2023

94noni deleted the issue-263 branch November 9, 2023 18:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Symfony v5.4 minimum #265

Upgrade to Symfony v5.4 minimum #265

94noni commented Jun 16, 2023 •

edited

Loading

94noni commented Jun 20, 2023

norkunas commented Jun 21, 2023

norkunas commented Jun 21, 2023

94noni commented Jun 21, 2023

brunoocasali commented Jun 21, 2023

94noni commented Jun 25, 2023

norkunas commented Jun 26, 2023

brunoocasali left a comment

brunoocasali commented Jul 3, 2023

94noni commented Jul 5, 2023 •

edited

Loading

brunoocasali commented Jul 10, 2023

norkunas commented Jul 11, 2023 •

edited

Loading

94noni commented Jul 11, 2023 •

edited

Loading

norkunas commented Jul 11, 2023

brunoocasali commented Jul 13, 2023

norkunas commented Jul 13, 2023

brunoocasali commented Jul 13, 2023

94noni commented Jul 29, 2023

brunoocasali commented Aug 3, 2023

94noni commented Aug 3, 2023

brunoocasali commented Aug 14, 2023

curquiza commented Sep 13, 2023

94noni commented Sep 13, 2023

norkunas Sep 13, 2023

Chris53897 commented Nov 1, 2023

94noni commented Nov 1, 2023

94noni commented Nov 9, 2023

Upgrade to Symfony v5.4 minimum #265

Upgrade to Symfony v5.4 minimum #265

Conversation

94noni commented Jun 16, 2023 • edited Loading

Pull Request

Related issue

What does this PR do?

94noni commented Jun 20, 2023

norkunas commented Jun 21, 2023

norkunas commented Jun 21, 2023

94noni commented Jun 21, 2023

brunoocasali commented Jun 21, 2023

94noni commented Jun 25, 2023

norkunas commented Jun 26, 2023

brunoocasali left a comment

Choose a reason for hiding this comment

brunoocasali commented Jul 3, 2023

94noni commented Jul 5, 2023 • edited Loading

brunoocasali commented Jul 10, 2023

norkunas commented Jul 11, 2023 • edited Loading

94noni commented Jul 11, 2023 • edited Loading

norkunas commented Jul 11, 2023

brunoocasali commented Jul 13, 2023

norkunas commented Jul 13, 2023

brunoocasali commented Jul 13, 2023

94noni commented Jul 29, 2023

brunoocasali commented Aug 3, 2023

94noni commented Aug 3, 2023

brunoocasali commented Aug 14, 2023

curquiza commented Sep 13, 2023

94noni commented Sep 13, 2023

norkunas Sep 13, 2023

Choose a reason for hiding this comment

Chris53897 commented Nov 1, 2023

94noni commented Nov 1, 2023

94noni commented Nov 9, 2023

94noni commented Jun 16, 2023 •

edited

Loading

94noni commented Jul 5, 2023 •

edited

Loading

norkunas commented Jul 11, 2023 •

edited

Loading

94noni commented Jul 11, 2023 •

edited

Loading