doc: quickstart guide errors #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidando73
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
aidando73
commented
Dec 6, 2024
| @@ -62,7 +62,7 @@ llama-stack-client --endpoint http://localhost:$LLAMA_STACK_PORT models list | |||
| You can test basic Llama inference completion using the CLI too. | |||
| ```bash | |||
| llama-stack-client --endpoint http://localhost:$LLAMA_STACK_PORT \ | |||
| inference chat_completion \ | |||
| inference chat-completion \ | |||
There was a problem hiding this comment.
aidando73
commented
Dec 6, 2024
| @@ -118,6 +118,7 @@ async def run_main(): | |||
| model=os.environ["INFERENCE_MODEL"], | |||
| instructions="You are a helpful assistant", | |||
| tools=[{"type": "memory"}], # enable Memory aka RAG | |||
| enable_session_persistence=True, | |||
There was a problem hiding this comment.
aidando73
commented
Dec 6, 2024
| @@ -139,7 +140,7 @@ async def run_main(): | |||
| attachments=attachments, | |||
| session_id=session_id, | |||
| ) | |||
| async for log in EventLogger().log(response): | |||
| for log in EventLogger().log(response): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses a few errors I got when running the quick start guide: https://llama-stack.readthedocs.io/en/latest/getting_started/index.html. We should keep this up to date to maintain engagement with the community.
I've annotated the PR below. Could you PTAL 🙏 ?
Before submitting