Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: quickstart guide errors #575

Merged
merged 4 commits into from
Dec 6, 2024
Merged

doc: quickstart guide errors #575

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0185d62
doc: typo in chat-completion command
aidando73 Dec 6, 2024
a2fc114
enable session persistence
aidando73 Dec 6, 2024
98ab8f2
doc: typo in chat-completion command
aidando73 Dec 6, 2024
eaf4392
async
aidando73 Dec 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/source/getting_started/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ llama-stack-client --endpoint http://localhost:$LLAMA_STACK_PORT models list
You can test basic Llama inference completion using the CLI too.
```bash
llama-stack-client --endpoint http://localhost:$LLAMA_STACK_PORT \
inference chat_completion \
inference chat-completion \
Copy link
Contributor Author

@aidando73 aidando73 Dec 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Quick start guide: https://llama-stack.readthedocs.io/en/latest/getting_started/index.html

See: https://github.com/meta-llama/llama-stack-client-python/blob/eb3d21932d22b863e5687eed2ce26e713ab46682/src/llama_stack_client/lib/cli/inference/inference.py#L21

--message "hello, what model are you?"
```

Expand Down Expand Up @@ -118,6 +118,7 @@ async def run_main():
model=os.environ["INFERENCE_MODEL"],
instructions="You are a helpful assistant",
tools=[{"type": "memory"}], # enable Memory aka RAG
enable_session_persistence=True,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes:

Screenshot 2024-12-06 at 19 19 18

Parameter is now required:

https://github.com/meta-llama/llama-stack-client-python/blob/eb3d21932d22b863e5687eed2ce26e713ab46682/src/llama_stack_client/types/shared/agent_config.py#L28

)

agent = Agent(client, agent_config)
Expand Down
Loading