Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make approval of imported entities work #319

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Make approval of imported entities work #319

merged 2 commits into from
Jul 17, 2024

Commits on Jul 9, 2024

  1. fix(imports): Explicitly set the entity BBID of approved imports 

    Not sure whether that is the best solution with Bookshelf.js, but this
prevents the following SQL error from crashing the server:

> error: insert into "bookbrainz"."author" ("alias_set_id", "begin_area_id", "begin_day", "begin_month", "begin_year", "disambiguation_id", "end_area_id", "end_day", "end_month", "end_year", "ended", "gender_id", "identifier_set_id", "revision_id", "type_id") values ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15) returning * - null value in column "bbid" violates not-null constraint
    @kellnerd
    kellnerd committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    ff30d4b View commit details
    Browse the repository at this point in the history

  2. refactor(imports): Return the Bookshelf model 

    We need it again to update the search index.
    @kellnerd
    kellnerd committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    817ec3f View commit details
    Browse the repository at this point in the history