Make approval of imported entities work #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure whether that is the best solution with Bookshelf.js, but this
prevents the following SQL error from crashing the server:
> error: insert into "bookbrainz"."author" ("alias_set_id", "begin_area_id", "begin_day", "begin_month", "begin_year", "disambiguation_id", "end_area_id", "end_day", "end_month", "end_year", "ended", "gender_id", "identifier_set_id", "revision_id", "type_id") values ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14, $15) returning * - null value in column "bbid" violates not-null constraint
We need it again to update the search index.
This was referenced Jul 15, 2024
MonkeyDo
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Approving imported entities currently fails on metabrainz/bookbrainz-site@6684575
Solution
approveImport) and the edit and approve workflow (createEntity)Areas of Impact
Only import related ORM functions are affected this time.
Doing an npm an release is not required yet, there will be more changes soon and I am using a local version of the ORM package anyway.