SEARCH-642 (schema): Drop id fields for cdstub and tag #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are not the unique identifiers we use and are not exposed. For cdstub we expose unique discid, for tag unique name.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SEARCH-642.
These are not the unique identifiers we use and are not exposed.
For cdstub we expose unique discid, for tag unique name.
Solution
This pull request stops making
ida searchable field for cdstub and tag.It also has to be removed it from being submitted by the indexer, see metabrainz/sir#118
Checklist for author
Action
Deploy this pull request
Deploy metabrainz/sir#118
Rebuild cdstub and tag search indexes