SEARCH-642 (indexer): Drop id fields for cdstub and tag #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
These are not the unique identifiers we use and are not exposed. For cdstub we expose unique discid, for tag unique name.
|
Just rebased on the latest |
Run the following commands to regenerate SQL files:
python -m sir triggers -bid 2
./GenerateDropSql.pl
yvanzo
reviewed
May 12, 2022
There was a problem hiding this comment.
Since it is a breaking change that requires updating mbsssssat the same time, and thus a new release of mb-solr, I would prefer to merge this pull request and release the related MB Solr schema change separately from the MB Postgres schema change, so as not to further complicate our tests and deployment steps.
LGTMBDNT otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SEARCH-642.
These are not the unique identifiers we use and are not exposed.
For cdstub we expose unique discid, for tag unique name.
Solution
This pull request stops filling this search field.
It also has to be removed it from search schema, see metabrainz/mbsssss#59
Checklist for author
Action
Deploy metabrainz/mbsssss#59
Deploy this pull request
Rebuild cdstub and tag search indexes