SEARCH-688 (I): Use raiseload in query loading options #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I did some more testing and it caught issues in artist core but missed the ones in label core. Putting this on hold for now. |
Use [raiseload](https://docs.sqlalchemy.org/en/14/orm/loading_relationships.html#sqlalchemy.orm.raiseload) loading technique in query options to raise an error on accessing attributes that haven't been eagerly loaded. There have been suboptimal SQL queries in sir previously due to missing columns in extrapaths or using hybrid attributes in fields or extrapaths which caused lazy loading. Since the attributes we access in SIR are fixed and remain the same, we should aim for loading all of those eagerly. raiseload will raise an error with a stacktrace to help us fix the issue if a lazy load happens, helping in performance debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use raiseload loading technique in query options to raise an error on accessing attributes that haven't been eagerly loaded. There have been suboptimal SQL queries in sir previously due to missing columns in extrapaths or using hybrid attributes in fields or extrapaths which caused lazy loading. Since the attributes we access in SIR are fixed and remain the same, we should aim for loading all of those eagerly. raiseload will raise an error with a stacktrace to help us fix the issue if a lazy load happens, helping in performance debugging.
Checklist for author