Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SEARCH-688 (I): Use raiseload in query loading options #154

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

SEARCH-688 (I): Use raiseload in query loading options #154

wants to merge 2 commits into from

Commits on Dec 8, 2022

  1. Use raiseload in query loading options 

    Use [raiseload](https://docs.sqlalchemy.org/en/14/orm/loading_relationships.html#sqlalchemy.orm.raiseload) loading technique in query options
to raise an error on accessing attributes that haven't been eagerly
loaded. There have been suboptimal SQL queries in sir previously due to
missing columns in extrapaths or using hybrid attributes in fields or
extrapaths which caused lazy loading. Since the attributes we access in
SIR are fixed and remain the same, we should aim for loading all of those
eagerly. raiseload will raise an error with a stacktrace to help us fix
the issue if a lazy load happens, helping in performance debugging.
    @amCap1712
    amCap1712 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    0120931 View commit details
    Browse the repository at this point in the history

  2. Limit lru_cache size

    @amCap1712
    amCap1712 committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    5a98b44 View commit details
    Browse the repository at this point in the history