-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 bump gosec to 2.17.0, and fix gosec for submodules #1218
Conversation
Gosec does not handle submodules well. Ignore them and run them separately so they run against correct dependencies. Bump gosec to 2.17.0, and fix new errors it has discovered. Manual cherry pick of metal3-io#1213, metal3-io#1214, and metal3-io#1181, metal3-io#1127, metal3-io#1137, metal3-io#1134 that bump golangci-lint workflow dependencies.
aa47790
to
1b397d1
Compare
/override test-ubuntu-e2e-integration-release-1-5 Integration will not test any of this. |
@tuminoid: Overrode contexts on behalf of tuminoid: test-ubuntu-e2e-integration-release-1-5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, smoshiur1237 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Gosec does not handle submodules well. Ignore them and run them separately so they run against correct dependencies.
Bump gosec to 2.17.0, and fix new errors it has discovered.
Manual cherry pick of #1213, #1214, and #1181 that bump golangci-lint workflow dependencies.
After this has been merged, PR in project-infra is needed to deactivate gosec in release-1.5, add "test" for release-1.5, and then gosec.sh needs to be removed in release-1.5 via another PR in this repo.
Release 1.4 and release 1.3 will not be bumped.