appIconsDecorator: Handle signal disconnections on destruction #2273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were removing the container set, but not its children, so let's cleanup everything when indicators are cleared. Closes: micheleg#2272, micheleg#2270
No need to use two objects, we can use labeled connections to simplify our case
Closed
3v1n0
force-pushed
the
handle-desactivation
branch
from
1a40155
to
35788bb
Compare
If we're tracking an object destruction and that object gets destroyed, we need to remove the signals handler storage item, or we'd end up trying to disconnect from it again when destroying the signals handler. Closes: micheleg#2270
3v1n0
force-pushed
the
handle-desactivation
branch
from
35788bb
to
78346d6
Compare
This was referenced Aug 26, 2024
vanvugt
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that we destroy the created objects and that we disconnect from all their signals on destruction.
Also, stop monitoring objects destruction in signal handler after an object has been destroyed.
Closes: #2272
Closes: #2270