Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

appIconsDecorator: Handle signal disconnections on destruction #2273

Merged
merged 6 commits into from
Aug 27, 2024
Merged

appIconsDecorator: Handle signal disconnections on destruction #2273

merged 6 commits into from
Aug 27, 2024

Commits on Aug 26, 2024

  1. appIconsDecorator: Use the generic icons signal handler for result

    @3v1n0
    3v1n0 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    9205c22 View commit details
    Browse the repository at this point in the history

  2. appIconsDecorator: Destroy indicators on removal 

    We were removing the container set, but not its children, so let's
cleanup everything when indicators are cleared.

Closes: micheleg#2272, micheleg#2270
    @3v1n0
    3v1n0 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    46b7d01 View commit details
    Browse the repository at this point in the history

  3. appIconsDecorator: Drop unneeded eslint ignores

    @3v1n0
    3v1n0 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    ee35fe4 View commit details
    Browse the repository at this point in the history

  4. appIconsDecorator: Use a signal signals handler with labels 

    No need to use two objects, we can use labeled connections to simplify
our case
    @3v1n0
    3v1n0 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    d7687c7 View commit details
    Browse the repository at this point in the history

  5. appIconIndicators: Use lambda-style callbacks for better debugging

    @3v1n0
    3v1n0 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    1a28cf3 View commit details
    Browse the repository at this point in the history

  6. utils: Remove signal handler item on object destruction 

    If we're tracking an object destruction and that object gets destroyed,
we need to remove the signals handler storage item, or we'd end up
trying to disconnect from it again when destroying the signals handler.

Closes: micheleg#2270
    @3v1n0
    3v1n0 committed Aug 26, 2024
    Configuration menu
    Copy the full SHA
    78346d6 View commit details
    Browse the repository at this point in the history