Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some compat quirk #1761

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

petamoriken
Copy link
Contributor

#1713 (comment)

types/web also has some compat quirk that had to mismatch with the spec, e.g. ChildNode being only a mixin interface inherited by some Node variants but types/web had to make it inherit from Node, reversing the inheritance, because back in the day we thought maybe we should put the compat first before correctness.

But if microsoft/TypeScript#58222 didn't break DefinitelyTyped then maybe it's a good chance to remove one quirk.

Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

@saschanaz
Copy link
Contributor

Oh I said the quirk #1713 is removing, not this quirk. I'm much less confident that this would be compatible with the ecosystem. But you can try submitting a draft PR into microsoft/TypeScript with this change and see what it catches.

@petamoriken petamoriken marked this pull request as draft August 3, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants