Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some compat quirk #1761

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Remove some compat quirk #1761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
342b08c
`ChildNode` and `ParentNode` stopped inheriting `Node`
petamoriken Jul 28, 2024
418edcb
`SVGSymbolElement` inherits from `SVGGraphicsElement`
petamoriken Jul 28, 2024
6f360b0
fix
petamoriken Jul 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5683,7 +5683,7 @@ declare var CharacterData: {
new(): CharacterData;
};

interface ChildNode extends Node {
interface ChildNode {
/**
* Inserts nodes just after node, while replacing strings in nodes with equivalent Text nodes.
*
Expand Down Expand Up @@ -15817,13 +15817,13 @@ interface Node extends EventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/childNodes)
*/
readonly childNodes: NodeListOf<ChildNode>;
readonly childNodes: NodeListOf<Node & ChildNode>;
/**
* Returns the first child.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/firstChild)
*/
readonly firstChild: ChildNode | null;
readonly firstChild: (Node & ChildNode) | null;
/**
* Returns true if node is connected and false otherwise.
*
Expand All @@ -15835,13 +15835,13 @@ interface Node extends EventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/lastChild)
*/
readonly lastChild: ChildNode | null;
readonly lastChild: (Node & ChildNode) | null;
/**
* Returns the next sibling.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/nextSibling)
*/
readonly nextSibling: ChildNode | null;
readonly nextSibling: (Node & ChildNode) | null;
/**
* Returns a string appropriate for the type of node.
*
Expand Down Expand Up @@ -15873,13 +15873,13 @@ interface Node extends EventTarget {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/parentNode)
*/
readonly parentNode: ParentNode | null;
readonly parentNode: (Node & ParentNode) | null;
/**
* Returns the previous sibling.
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/previousSibling)
*/
readonly previousSibling: ChildNode | null;
readonly previousSibling: (Node & ChildNode) | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/textContent) */
textContent: string | null;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Node/appendChild) */
Expand Down Expand Up @@ -16502,7 +16502,7 @@ declare var PannerNode: {
new(context: BaseAudioContext, options?: PannerOptions): PannerNode;
};

interface ParentNode extends Node {
interface ParentNode {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/Document/childElementCount) */
readonly childElementCount: number;
/**
Expand Down Expand Up @@ -20413,7 +20413,7 @@ declare var SVGSwitchElement: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/SVGSymbolElement)
*/
interface SVGSymbolElement extends SVGElement, SVGFitToViewBox {
interface SVGSymbolElement extends SVGGraphicsElement, SVGFitToViewBox {
addEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGSymbolElement, ev: SVGElementEventMap[K]) => any, options?: boolean | AddEventListenerOptions): void;
addEventListener(type: string, listener: EventListenerOrEventListenerObject, options?: boolean | AddEventListenerOptions): void;
removeEventListener<K extends keyof SVGElementEventMap>(type: K, listener: (this: SVGSymbolElement, ev: SVGElementEventMap[K]) => any, options?: boolean | EventListenerOptions): void;
Expand Down
21 changes: 6 additions & 15 deletions inputfiles/overridingTypes.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
{
"mixins": {
"mixin": {
"ChildNode": {
"extends": "Node"
},
"ParentNode": {
"extends": "Node"
},
"Animatable": {
"methods": {
"method": {
Expand Down Expand Up @@ -902,25 +896,25 @@
"properties": {
"property": {
"parentNode": {
"overrideType": "ParentNode"
"overrideType": "Node & ParentNode"
},
"parentElement": {
"overrideType": "HTMLElement"
},
"childNodes": {
"overrideType": "NodeListOf<ChildNode>"
"overrideType": "NodeListOf<Node & ChildNode>"
},
"firstChild": {
"overrideType": "ChildNode"
"overrideType": "Node & ChildNode"
},
"lastChild": {
"overrideType": "ChildNode"
"overrideType": "Node & ChildNode"
},
"nextSibling": {
"overrideType": "ChildNode"
"overrideType": "Node & ChildNode"
},
"previousSibling": {
"overrideType": "ChildNode"
"overrideType": "Node & ChildNode"
}
}
}
Expand Down Expand Up @@ -1268,9 +1262,6 @@
}
}
},
"SVGSymbolElement": {
"extends": "SVGElement"
},
"FormData": {
"methods": {
"method": {
Expand Down