-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docsy #244
Update Docsy #244
Conversation
@@ -0,0 +1,4 @@ | |||
github.com/FortAwesome/Font-Awesome v0.0.0-20240402185447-c0f460dca7f7/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample file, has more content: (See https://github.com/google/docsy-example/blob/main/go.sum)
github.com/FortAwesome/Font-Awesome v0.0.0-20240402185447-c0f460dca7f7/go.mod h1:IUgezN/MFpCDIlFezw3L8j83oeiIuYoj28Miwr/KUYo=
github.com/google/docsy v0.10.0 h1:6tMDacPwAyRWNCfvsn/9qGOZDQ8b0aRzjRZvnZPY5dg=
github.com/google/docsy v0.10.0/go.mod h1:c0nIAqmRTOuJ01F85U/wJPQtc3Zj9N58Kea9bOT2AJc=
github.com/google/docsy v0.10.1-0.20240516225026-36746913371a h1:Fmx4SmmyWZf4q3rq9jhVWr6/h2MKEi4+61irjQO2ylI=
github.com/google/docsy v0.10.1-0.20240516225026-36746913371a/go.mod h1:c0nIAqmRTOuJ01F85U/wJPQtc3Zj9N58Kea9bOT2AJc=
github.com/google/docsy v0.10.1-0.20240528200232-6549143cf323 h1:T4UiGpcrIgiuyQj0tc7BtJwv6u736J8Jnl4QZno0fk4=
github.com/google/docsy v0.10.1-0.20240528200232-6549143cf323/go.mod h1:c0nIAqmRTOuJ01F85U/wJPQtc3Zj9N58Kea9bOT2AJc=
github.com/google/docsy v0.10.1-0.20240529105443-333c2f8d4172 h1:1gAAuOfHRok/hJqfF+wpjOYqlH0d76dwUsskLEnOzxo=
github.com/google/docsy v0.10.1-0.20240529105443-333c2f8d4172/go.mod h1:c0nIAqmRTOuJ01F85U/wJPQtc3Zj9N58Kea9bOT2AJc=
github.com/twbs/bootstrap v5.3.3+incompatible/go.mod h1:fZTSrkpSf0/HkL0IIJzvVspTt1r9zuf7XlZau8kpcY0=
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've followed the steps in https://www.docsy.dev/docs/updating/convert-site-to-module/#import-the-docsy-theme-module-as-a-dependency-of-your-site, which automatically generated the go.sum
and go.mod
files.
Based on the commit history of the file, I assume they've added the additional docsy version dependencies to test the new RTL feature.
Would leave the content on it's initial, auto-generated state.
@@ -4,7 +4,7 @@ languageCode = 'en-us' | |||
title = 'AL Guidelines' | |||
|
|||
# Hugo allows theme composition (and inheritance). The precedence is from left to right. | |||
theme = ["docsy"] | |||
theme = ["github.com/google/docsy"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample does not specify a theme, but has the following content to use Docsy as a module (See https://www.docsy.dev/docs/get-started/docsy-as-module/)
Sample config file:
module:
# Uncomment the next line to build and serve using local docsy clone declared in the named Hugo workspace:
# workspace: docsy.work
hugoVersion:
extended: true
min: 0.110.0
imports:
- path: github.com/google/docsy
disable: false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the migration guide, it was mentioned that the value can be changed from theme = ["docsy"]
to theme = ["github.com/google/docsy"]
(https://www.docsy.dev/docs/updating/convert-site-to-module/#update-your-config-file).
Alternatively, we could add the example you've provided. Should I adapt these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are no 'Content" changes - This is a technical update of the Theme.
Hello there,
wanted to add new content to AL Guidelines. Unfortunately it seems to be a bit outdated, as it used the Docsy theme from 2 -3 years ago, but with the latest hugo version, which causes some errors in a GitHub Codespace:
hugo v0.133.1-47d00202e7e61769ce4d14691e43b27852c9cce4+extended linux/amd64 BuildDate=2024-08-26T13:58:46Z VendorInfo=gohugoio
hugo serve
Todos:
replaces node entirely, removed package.json filesNode needed for hugo building step)hugo.yaml
workflow runs successfullyNoticed only 1 big change in design so far, see the header in the following picture:
Feel free to edit this PR.
Detailed error information:
ERROR deprecated: config: languages.en.description: custom params on the language top level was deprecated in Hugo v0.112.0 and will be removed in Hugo 0.134.0
executing "home.html" at : error calling partial