Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docsy #244
Update Docsy #244
Changes from 15 commits
273de37
2520893
77c64d7
3df1322
234a95f
70a0e69
6d868fb
3b4f6ed
6807e6f
6f79046
1955b65
d4d8d0f
1edf28a
bc536ab
102dc94
911cf76
8ba7e0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample file, has more content: (See https://github.com/google/docsy-example/blob/main/go.sum)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've followed the steps in https://www.docsy.dev/docs/updating/convert-site-to-module/#import-the-docsy-theme-module-as-a-dependency-of-your-site, which automatically generated the
go.sum
andgo.mod
files.Based on the commit history of the file, I assume they've added the additional docsy version dependencies to test the new RTL feature.
Would leave the content on it's initial, auto-generated state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample does not specify a theme, but has the following content to use Docsy as a module (See https://www.docsy.dev/docs/get-started/docsy-as-module/)
Sample config file:
https://github.com/google/docsy-example/blob/604f8183399ebc25e53dfd08f5607817e21a2871/hugo.yaml#L212:L220
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the migration guide, it was mentioned that the value can be changed from
theme = ["docsy"]
totheme = ["github.com/google/docsy"]
(https://www.docsy.dev/docs/updating/convert-site-to-module/#update-your-config-file).Alternatively, we could add the example you've provided. Should I adapt these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can do that in a separate PR later. But I do think we should get the update "all the way"