Cloud init lisa #11423
Open
Cloud init lisa #11423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 11, 2024 16:48
reubeno
reviewed
Dec 12, 2024
| @staticmethod | ||
| def link_rename(current_name: str, new_name: str): | ||
| subp.subp(["ip", "link", "set", current_name, "name", new_name]) | ||
| + time.sleep(0.5) |
There was a problem hiding this comment.
Is this an upstream-provided fix? I'm concerned seeing a sleep call get added to address what is being labeled a race condition. It tends to sweep the true root cause under the rug, and often runs the risk of still not mitigating the issue appropriately for some percentage of scenarios.
|
The patch provided has no comments, and there's very little context in this PR. Will you please revise the PR to include a clear description of the identified problem, the nature of the proposed fix, any other relevant details? |
microsoft-github-policy-service
bot
added
Schema
|
This is a test PR not ready for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
What does the PR accomplish, why was it needed?
Change Log
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology