-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud init lisa #11423
Closed
Closed
Cloud init lisa #11423
Changes from 7 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d12c004
upgrade cloud-int to 24.3
ab89166
rebase
8ce65e7
Merge branch '3.0-dev' of https://github.com/microsoft/azurelinux int…
fad5b21
Merge branch '3.0-dev' of https://github.com/microsoft/azurelinux int…
af58fcc
add patch
25ab997
add patch
578cd4b
add patch
c16a527
add patch
eead911
add patch
19d0dc7
update grub
366de76
update grub
607f2ad
update grub
9d2b0f8
update grub
6b7ff73
modify config
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
Summary: Cloud instance init scripts | ||
Name: cloud-init | ||
Version: 24.3.1 | ||
Release: 1%{?dist} | ||
Release: 2%{?dist} | ||
License: GPLv3 | ||
Vendor: Microsoft Corporation | ||
Distribution: Azure Linux | ||
|
@@ -11,6 +11,7 @@ Source0: https://github.com/canonical/%{name}/archive/refs/tags/%{version | |
Source1: 10-azure-kvp.cfg | ||
Patch0: Add-Network-Interface-Renaming-Support-for-CAPM3-Met.patch | ||
Patch1: no-single-process.patch | ||
Patch2: network_renaming.patch | ||
%define cl_services cloud-config.service cloud-config.target cloud-final.service cloud-init.service cloud-init.target cloud-init-local.service | ||
BuildRequires: automake | ||
BuildRequires: dbus | ||
|
@@ -142,6 +143,9 @@ make check %{?_smp_mflags} | |
%config(noreplace) %{_sysconfdir}/cloud/cloud.cfg.d/10-azure-kvp.cfg | ||
|
||
%changelog | ||
* Wed Dec 11 2024 Minghe Ren <[email protected]> - 24.3.1-2 | ||
- Add patch to avoid cloud-init nics renaming race condition | ||
|
||
* Tue Oct 01 2024 Minghe Ren <[email protected]> - 24.3.1-1 | ||
- Upgrade cloud-init to 24.3.1 to support azure-proxy-agent | ||
- Add upstream patch no-single-process.patch to revert a behavior change on cloud-init systemd | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
diff -ruN a/cloudinit/net/netops/iproute2.py b/cloudinit/net/netops/iproute2.py | ||
--- a/cloudinit/net/netops/iproute2.py 2024-09-04 12:01:58.000000000 -0700 | ||
+++ b/cloudinit/net/netops/iproute2.py 2024-12-11 17:00:35.590222604 -0800 | ||
@@ -2,7 +2,7 @@ | ||
|
||
from cloudinit import subp | ||
from cloudinit.net.netops import NetOps | ||
- | ||
+import time | ||
|
||
class Iproute2(NetOps): | ||
@staticmethod | ||
@@ -30,6 +30,7 @@ | ||
@staticmethod | ||
def link_rename(current_name: str, new_name: str): | ||
subp.subp(["ip", "link", "set", current_name, "name", new_name]) | ||
+ time.sleep(0.5) | ||
|
||
@staticmethod | ||
def add_route( | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an upstream-provided fix? I'm concerned seeing a sleep call get added to address what is being labeled a race condition. It tends to sweep the true root cause under the rug, and often runs the risk of still not mitigating the issue appropriately for some percentage of scenarios.