Migrate yarn to npm #22116
Open
Migrate yarn to npm #22116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fs-eire
reviewed
Sep 18, 2024
to replace yarn e2e start. This way we will need to run `npm run e2e:start`.
jchen351
commented
Sep 18, 2024
| @@ -15,7 +15,7 @@ end | |||
| def shared | |||
| config = use_native_modules! | |||
|
|
|||
| use_react_native!(:path => config["reactNativePath"]) | |||
| use_react_native!(:path => '../node_modules/react-native') | |||
There was a problem hiding this comment.
Not sure why config["reactNativePath"]) has become nil. @fs-eire Do you know the reason behind this?
https://dev.azure.com/onnxruntime/onnxruntime/_build/results?buildId=1496652&view=logs&j=de302ec2-2305-57e0-e8c6-cd89c569f2a3&t=ec15b2e4-bc91-5a2a-85fd-a369ed3087c3&l=24
# Conflicts: # js/react_native/android/gradle.properties # js/react_native/android/gradle/wrapper/gradle-wrapper.properties # js/react_native/e2e/android/app/build.gradle # js/react_native/e2e/android/build.gradle
|
Not sure how long will this PR take. The following PRs are for upgrading the package version of the yarn lock file: |
|
To get this PR closed, you need to upgrade Gradle first. Is it right？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR change all reference to yarn to npm
Motivation and Context
This PR is needed to address all Component Governce issue that ORT is facing
Current issue
use_react_native!(:path => config["reactNativePath"]) return nil
For error
CocoaPods could not find compatible versions for pod "RCTRequired", we might need to increase iOS targe version from 13.0 to a higher version.For 'react-native' >= 0.73.x , react-native/react.gradle file is no longer used
We need to update to gradle 7.6 or above to upgrade the RN. current gradlew version 7.3.3 that we use does not works on RN 71+.
Instruction on how to implement the React-Native has changed since 0.72.
Error
The new Java toolchain feature cannot be used at the project level in combination with source and/or target compatibilityfrom gradle.duplicate class: com.facebook.react.PackageList
solution: remove
apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)from bottom of andoird/app/build.gradleNeed to update the OnnxruntimeModuleTest because
ReactApplicationContextis now a abstract class.