Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4056, Debugger statements in production code #4082

Conversation

paulober
Copy link
Contributor

This change addresses item #4056

This changes [[visible behavior/performance/documentation/etc.]]

The following changes are proposed:

  • Guard debugger; statements with checks for if the code is running in development mode (already controlled by the mode switch on webpack)

@gcampbell-msft
Copy link
Collaborator

@paulober Apologies for the delay, as I was unavailable for some time, could you please update this PR to be up-to-date with main? Then, I can re-approve and merge.

@gcampbell-msft
Copy link
Collaborator

@paulober Wow, speedy! Re-approved, once it passes tests it should merge.

@gcampbell-msft gcampbell-msft enabled auto-merge (squash) September 30, 2024 11:16
@gcampbell-msft gcampbell-msft merged commit 9b6e016 into microsoft:main Sep 30, 2024
4 checks passed
@paulober paulober deleted the fix-4056-debugger-statements-in-production branch October 1, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants