Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #4056, Debugger statements in production code #4082

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Fix #4056, Debugger statements in production code #4082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5bbead
Fix #4056, Debugger statements in production code
paulober Sep 18, 2024
f29bb08
Merge branch 'main' into fix-4056-debugger-statements-in-production
paulober Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/drivers/cmakeServerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,9 @@ export class CMakeServerClient {
break;
}
if (mat.length !== 3) {
debugger;
if (process.env.NODE_ENV === 'development') {
debugger;
}
throw new global.Error(localize('protocol.error.cmake', 'Protocol error talking to CMake! Got this input: {0}', input));
}
this.accInput = mat[2];
Expand Down Expand Up @@ -474,7 +476,9 @@ export class CMakeServerClient {
}
}
}
debugger;
if (process.env.NODE_ENV === 'development') {
debugger;
}
log.warning(localize('cant.yet.handle.message', 'Can\'t yet handle the {0} messages', some.type));
}

Expand Down Expand Up @@ -587,7 +591,9 @@ export class CMakeServerClient {
pipe.on('error', e => {
pipe.end();
if (!this.shutDownFlag) {
debugger;
if (process.env.NODE_ENV === 'development') {
debugger;
}
rollbar.takePromise(localize('pipe.error.from.cmake-server', 'Pipe error from cmake-server'),
{ pipe: pipeFile },
params.onPipeError(e));
Expand Down
4 changes: 3 additions & 1 deletion src/projectOutline/projectOutline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,9 @@ export class TargetNode extends BaseNode {
].join(',');
return item;
} catch (e) {
debugger;
if (process.env.NODE_ENV === 'development') {
debugger;
}
return new vscode.TreeItem(`${this.name} (${localize('item.render.issue', 'There was an issue rendering this item. This is a bug')})`);
}
}
Expand Down
4 changes: 3 additions & 1 deletion src/rollbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ class RollbarController {
*/
error(what: string, additional: object = {}): void {
log.error(what, JSON.stringify(additional, (key, value) => stringifyReplacer(key, value)));
debugger;
if (process.env.NODE_ENV === 'development') {
debugger;
}
}

info(what: string, additional: object = {}): void {
Expand Down
Loading