Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#6671: don't iterate over the result of the Series.tolist function #6672

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Oct 22, 2023

What do these changes do?

Removes useless iteration over the result.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Do not iterate over the result of the Series.tolist function. #6671
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review October 22, 2023 15:47
@anmyachev anmyachev requested a review from a team as a code owner October 22, 2023 15:47
@YarShev YarShev merged commit 3ebbf96 into modin-project:master Oct 31, 2023
37 checks passed
@anmyachev anmyachev deleted the issue6671 branch October 31, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not iterate over the result of the Series.tolist function.
3 participants