Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF-#6671: don't iterate over the result of the Series.tolist function #6672

Merged
merged 1 commit into from
Oct 31, 2023
Merged

PERF-#6671: don't iterate over the result of the Series.tolist function #6672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions modin/core/storage_formats/base/query_compiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,9 @@ def default_to_pandas(self, pandas_op, *args, **kwargs):
warnings.filterwarnings("ignore", category=FutureWarning)
result = pandas_op(try_cast_to_pandas(self), *args, **kwargs)
if isinstance(result, (tuple, list)):
if "Series.tolist" in pandas_op.__name__:
YarShev marked this conversation as resolved.
Show resolved Hide resolved
# fast path: no need to iterate over the result from `tolist` function
YarShev marked this conversation as resolved.
Show resolved Hide resolved
return result
return [self.__wrap_in_qc(obj) for obj in result]
return self.__wrap_in_qc(result)

Expand Down