Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rm deprecated action and bash scripts #2092

Closed
wants to merge 1,075 commits into from
Closed

rm deprecated action and bash scripts #2092

wants to merge 1,075 commits into from

Conversation

ThomasHepworth
Copy link
Contributor

Type of PR

  • BUG
  • FEAT
  • MAINT
  • DOC

Overview

This PR removes deprecated bash scripts that are no longer needed in Splink 4. Originally, the scripts included in this PR aimed to automate cleanup tasks on text and dialect-specific files.

To provide a summary:

ADBond and others added 30 commits February 15, 2024 13:16
@ADBond
remove external references to _source_dataset_column_name_is_required
38342bf
@ADBond
source_dataset_column_name logic -> column_info_settings
d95d245
@ADBond
correct new references
e59704a
@ADBond
unique id -> column info settings
3988735
@ADBond
copy mutable in InputColumn
943a775
@ADBond
get sql_dialect from column_info_settings if we can/need
e72ffd4
@ADBond
settings mostly keyword only
622d128
@ADBond
make sure lambda updates properly in em training
08287a9
@ADBond
lint with black
ed371cc
@RobinL
Merge branch 'splink4_dev' into splink4_examples_notebooks
55a5a11
@RobinL
Merge branch 'master' into merge_master
55b53cc
@RobinL
fix changes lost in merge
0f85a90
@RobinL
fix changes lost in merge
371500e
@RobinL
restore splink4 deps
4644a12
@RobinL
update deps to include igraph
bf8371d
@RobinL
update lockfile
d8120e8
@RobinL
update toml
7214c6d
@RobinL
update lockfile
76da266
@RobinL
absolute date time difference functions now allow string parsing
3f20ffa
@RobinL
more rigour over column types for date time functions
3142c4c
@RobinL
format
dd5f0b7
@RobinL
update some of the tests
3552b7c
@RobinL
more tests pass
488b211
@ADBond
remove duplicate code
d4c8fae
@ADBond
simple test to catch branch
42032b5
@ADBond
Merge pull request #1972 from moj-analytical-services/merge_master
34ca2cd 
Merge master into splink4_dev
@ADBond
Merge pull request #1967 from moj-analytical-services/settings-splitting
90c0455 
Settings object - splitting attributes
@ADBond
compute_new_parameters_sql takes a bit less
350fa23
@ADBond
hints and breaking down parameters
5ff9fd7
@ADBond
split out core model settings (but still wired up)
c84857a
ADBond and others added 18 commits March 14, 2024 10:04
@ADBond
lint with black
96bd6cd
@ADBond
clearer type - Sequence for covariance
bccf9f3
@ADBond
split out logic for getting cluster ids when not supplied
e146b48
@RobinL
deal with views
12884a1
@ADBond
Merge pull request #2051 from moj-analytical-services/type-hinting-im…
50e0008 
…provements

Type hinting improvements - mypy conformance
@RobinL
Merge branch 'splink4_dev' into profile_columns_cleanup
ace09c4
@RobinL
Merge pull request #2058 from moj-analytical-services/profile_columns…
a6ed0bd 
…_cleanup

Clean up materialised tables that Splink creates when we're not using linker.py (profiling)
@RobinL
Merge branch 'splink4_dev' into merge_3_to_4_2064
580ea64
@RobinL
update notebook for sam's new chart
be622fe
@RobinL
Merge pull request #2065 from moj-analytical-services/merge_3_to_4_2064
d41c3a0 
Merge 3 to 4 2064
@RobinL
release
de103d3
@RobinL
Merge pull request #2077 from moj-analytical-services/splink4_release…
a941f31 
…_dev3

Splink4 release dev3
@RobinL
update pyproject for dev release
774d593
@RobinL
Merge pull request #2078 from moj-analytical-services/update_pyproject
9593ca6 
update pyproject for dev release
@RobinL
update release workflow
2bebe00
@RobinL
update colab links
c9f05cb
@RobinL
Merge pull request #2080 from moj-analytical-services/update_colab_links
1bc1277 
update colab links
@ThomasHepworth
rm deprecated action and bash scripts
313ac86
RobinL
RobinL requested changes Mar 25, 2024
View reviewed changes
Copy link
Member

@RobinL RobinL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this target the splink4_dev branch?

@ThomasHepworth
Copy link
Contributor Author

Should this target the splink4_dev branch?

Yeah, I think that's sensible.

@ThomasHepworth ThomasHepworth changed the base branch from master to splink4_dev March 25, 2024 12:02
@ThomasHepworth
Copy link
Contributor Author

@RobinL it appears there were some un-merged changes on master, so this PR is now also incorporating those in Splink4_dev.

Happy to re-create this PR off splink4_dev if you'd prefer that occurred in a separate PR.

@ThomasHepworth ThomasHepworth changed the base branch from splink4_dev to master March 25, 2024 14:50
@ThomasHepworth
Copy link
Contributor Author

Closing in favour of - #2094 which resets the commit history

@ThomasHepworth ThomasHepworth deleted the maint/clean_up_deprecated_actions branch March 25, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinL RobinL Awaiting requested review from RobinL

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasHepworth @RobinL @ADBond