Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

Add ngrok startup script. #27

Merged
merged 5 commits into from
May 20, 2020
Merged

Add ngrok startup script. #27

merged 5 commits into from
May 20, 2020

Conversation

NMNS93
Copy link

@NMNS93 NMNS93 commented May 19, 2020

This change is Reviewable

@NMNS93 NMNS93 self-assigned this May 19, 2020
Copy link
Contributor

@aledj2 aledj2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @aledj2, @Graeme-Smith, @natashapinto, and @NMNS93)


ngrok_start.sh, line 25 at r1 (raw file):

  NGROK_URL=$(curl http://localhost:4040/api/tunnels 2>/dev/null | jq ".tunnels[0].public_url") 
  echo $NGROK_URL
fi

can we echo $NGROK_URL to sys log and set up a slack alert for new url?>

Copy link
Contributor

@aledj2 aledj2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Graeme-Smith and @natashapinto)


ngrok_start.sh, line 25 at r1 (raw file):

Previously, aledj2 (Aled Jones) wrote…

can we echo $NGROK_URL to sys log and set up a slack alert for new url?>

done

Copy link
Contributor

@aledj2 aledj2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Graeme-Smith and @natashapinto)

@aledj2 aledj2 merged commit f0f31e3 into master May 20, 2020
@aledj2 aledj2 deleted the development branch May 20, 2020 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants