Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICD11 --> ORDO mappings #12

Merged
merged 4 commits into from
Apr 18, 2024
Merged

ICD11 --> ORDO mappings #12

merged 4 commits into from
Apr 18, 2024

Conversation

joeflack4
Copy link
Contributor

@joeflack4 joeflack4 commented Mar 28, 2024

About

ICD11<->ORDO Mappings

See: Strategy

Here's the google sheet for Mondo->ICD11.

Changes

ORDO Mappings

  • Add: New release output: ordo-icd11foundation.sssom.tsv
    • Completed work in mappings.py
    • Add: utils.py for this: This file now has several functions that are exactly the same in several repositories. Needs to be put into a package.
  • Update: config/icd11.sssom-metadata.yml: removed some unnecessary entries. Added necessary ones.
  • Add: requirements*.txt files: for installation of Python packages; and updated readme about that.
  • Delete: Temporary anlalysis files in src/compare_*/
  • Add: icd11mms-exact-matches.sparql for querying ordo.owl for mappings. But this may not be necessary and may get removed.
  • Add: src/temp_compare_matches_owl_and_nomenclature.py: Temporary file for analysis for comparing Ordo->ICD11MMS exact matches from nomenclature file and from OWL release.
  • Add: New release output: mondo-icd11foundation.sssom.tsv

Related


CC @souzadevinicius This is a PR to get ICD11Foundation<->Orphanet mappings, from Orphanet. We don't have standalone Orphanet repo, so I added them here. We can use these to get Mondo->ICD11Foundation mappings.

@joeflack4 joeflack4 marked this pull request as draft March 28, 2024 00:34
@joeflack4 joeflack4 added the enhancement New feature or request label Mar 28, 2024
@joeflack4 joeflack4 self-assigned this Mar 28, 2024
@joeflack4 joeflack4 linked an issue Mar 28, 2024 that may be closed by this pull request
@joeflack4 joeflack4 force-pushed the ordo-mappings2 branch 2 times, most recently from e560425 to 6660152 Compare March 28, 2024 00:42
makefile Show resolved Hide resolved
matentzn

This comment was marked as duplicate.

Exploratory analysis to try to find the best way to get ORDO<->ICD11Foundation mappings.
Exploratory analysis to try to find the best way to get ORDO<->ICD11Foundation mappings.
@joeflack4 joeflack4 force-pushed the ordo-mappings2 branch 3 times, most recently from fe1a0de to 43399a0 Compare March 29, 2024 00:08
@joeflack4 joeflack4 marked this pull request as ready for review March 30, 2024 00:14
src/mappings.py Outdated Show resolved Hide resolved
@joeflack4 joeflack4 force-pushed the ordo-mappings2 branch 4 times, most recently from 1b4b0a9 to c18a3c2 Compare March 30, 2024 20:48
makefile Outdated Show resolved Hide resolved
src/utils.py Outdated Show resolved Hide resolved
- Add: New release output: ordo-icd11.sssom.tsv
  - Completed work in mappings.py
  - Add: utils.py for this: This file now has several functions that are exactly the same in several repositories. Needs to be put into a package.
- Update: config/icd11.sssom-metadata.yml: removed some unnecessary entries. Added necessary ones.
- Add: requirements*.txt files: for installation of Python packages; and updated readme about that.
- Delete: Temporary anlalysis files in src/compare_*/
- Add: icd11mms-exact-matches.sparql for querying ordo.owl for mappings. But this may not be necessary and may get removed.
- Add: src/temp_compare_matches_owl_and_nomenclature.py: Temporary file for analysis for comparing Ordo->ICD11MMS exact matches from nomenclature file and from OWL release.
- Bug fix: run.sh: Updated to an older version that works.
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

makefile Outdated Show resolved Hide resolved
a.txt Outdated Show resolved Hide resolved
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change my review to comment due to the wrongly commented a.txt file

src/mappings.py Outdated Show resolved Hide resolved
@joeflack4 joeflack4 force-pushed the ordo-mappings2 branch 3 times, most recently from 624aa09 to c69a1cc Compare April 15, 2024 23:55
config/icd11.sssom-metadata.yml Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
makefile Outdated Show resolved Hide resolved
@joeflack4 joeflack4 force-pushed the ordo-mappings2 branch 3 times, most recently from 0f0110d to e3a3a56 Compare April 16, 2024 00:11
makefile Show resolved Hide resolved
- Delete: Unnecessary files and goals: temp analysis, getting of ordo.owl and querying it via SPARQL.
- Add: SSSOM validation
- Update: Replaced ad hoc SSSOM utilities with the ones from sssom-py
- Add: mondo-icd11 mappings
- Rename: SSSOM files: icd11 -> icd11foundation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICD11 --> ORDO mappings
3 participants