Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: omim.sssom.tsv #102

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Bugfix: omim.sssom.tsv #102

merged 1 commit into from
Jul 5, 2023

Conversation

joeflack4
Copy link
Contributor

Updates

  • Bugfix: omim.sssom.tsv was not able to be built due to missing ontology declaration

@joeflack4 joeflack4 self-assigned this Jul 5, 2023
@joeflack4 joeflack4 added the bug Something isn't working label Jul 5, 2023
@joeflack4 joeflack4 linked an issue Jul 5, 2023 that may be closed by this pull request
Release: Include omim.sssom.tsv to GH action #92
Closed
2 tasks
joeflack4
joeflack4 commented Jul 5, 2023
View reviewed changes
omim2obo/main.py
@@ -137,6 +137,7 @@ def omim2obo(use_cache: bool = False):

# Populate graph
# - Non-OMIM triples
graph.add((URIRef('http://purl.obolibrary.org/obo/mondo/omim.owl'), RDF.type, OWL.Ontology))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matentzn Your suggestion worked.

.github/workflows/buid_and_release.yml
@@ -28,8 +28,7 @@ jobs:
- name: build
# TODO: change to make all when fixed: https://github.com/monarch-initiative/omim/issues/92
run: |
make automated-release-artefacts
# make all
make all
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After confirming the fix worked locally, I reactivated omim.sssom.tsv for the action, ran it, and confirmed it generated a new release successfully with omim.sssom.tsv included.

@joeflack4 joeflack4 merged commit 95cdcf3 into main Jul 5, 2023
1 check passed
@joeflack4 joeflack4 deleted the bugfix-sssom branch July 5, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joeflack4 joeflack4

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release: Include omim.sssom.tsv to GH action
1 participant
@joeflack4