Improve product and taxon repository requests to list objects

monsieurbiz · Apr 9, 2024 · 72762e7 · 72762e7
1 parent 49df1f8
commit 72762e7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 4 deletions.
diff --git a/src/Provider/ProductUrlProvider.php b/src/Provider/ProductUrlProvider.php
@@ -36,12 +36,16 @@ public function __construct(
 
     public function getItems(string $locale): array
     {
-        $products = $this->productRepository->findBy(['enabled' => true]);
+        $products = $this->productRepository->createListQueryBuilder($locale)
+            ->andWhere('o.enabled = :enabled')
+            ->setParameter('enabled', true)
+            ->getQuery()
+            ->getResult()
+        ;
 
         $items = [];
         /** @var ProductInterface $product */
         foreach ($products as $product) {
-            $product->setCurrentLocale($locale); // To have translated name and slug with given locale
             $items[] = [
                 'name' => $product->getName(),
                 'value' => $this->router->generate('sylius_shop_product_show', ['slug' => $product->getSlug(), '_locale' => $locale]),

diff --git a/src/Provider/TaxonUrlProvider.php b/src/Provider/TaxonUrlProvider.php
@@ -36,15 +36,21 @@ public function __construct(
 
     public function getItems(string $locale): array
     {
-        $taxons = $this->taxonRepository->findBy(['enabled' => true]);
+        $taxons = $this->taxonRepository->createListQueryBuilder()
+            ->andWhere('translation.locale = :locale')
+            ->andWhere('o.enabled = :enabled')
+            ->setParameter('locale', $locale)
+            ->setParameter('enabled', true)
+            ->getQuery()
+            ->getResult()
+        ;
 
         $items = [];
         /** @var TaxonInterface $taxon */
         foreach ($taxons as $taxon) {
             if ($taxon->isRoot()) {
                 continue;
             }
-            $taxon->setCurrentLocale($locale); // To have translated name and slug with given locale
             $items[] = [
                 'name' => $this->getTaxonFullName($taxon),
                 'value' => $this->router->generate('sylius_shop_product_index', ['slug' => $taxon->getSlug(), '_locale' => $locale]),