This repository has been archived by the owner on Aug 26, 2022. It is now read-only.
Support SFTP in ACH file transfers #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed before, whoops.
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 55.98% 55.35% -0.64%
==========================================
Files 27 30 +3
Lines 3653 3906 +253
==========================================
+ Hits 2045 2162 +117
- Misses 1197 1300 +103
- Partials 411 444 +33
Continue to review full report at Codecov.
|
Our tests are a bit slow to launch, but we should allow a (crude) retry here anyway.
This was a suggested example in some EOF related issues, however setting it this low might be too strict for a default.
adamdecaf
force-pushed
the
split-out-file-transfers
branch
from
a4782d0 to
1a9798f
Compare
adamdecaf
force-pushed
the
split-out-file-transfers
branch
from
d4d75df to
70a263c
Compare
adamdecaf
changed the title
adamdecaf
force-pushed
the
split-out-file-transfers
branch
from
f78c8b7 to
ea6eda1
Compare
This helps fixup for SFTP where the paths are slightly different.
wadearnold
approved these changes
Jul 23, 2019
|
Yea and something in paygate's |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds SFTP (SSH File Transfer Protocol) support into paygate. The interface of
filetransfer.Agentis the critical interface to implement.This change also moves some logic out of paygate's root package to isolate it from the big mess of code in the root package. Initially everything was piled into one package for quicker development.
Issue: #170
Issue: #161