Support SFTP in ACH file transfers

README.md

@@ -131,7 +131,7 @@ Based on `DATABASE_TYPE` the following environment variables will be read to con
 
 ##### MySQL
 
-- `MYSQL_ADDRESS`: TCP address for connecting to the mysql server. (example: `localhost:3306`)
+- `MYSQL_ADDRESS`: TCP address for connecting to the mysql server. (example: `tcp(hostname:3306)`)
 - `MYSQL_DATABASE`: Name of database to connect into.
 - `MYSQL_PASSWORD`: Password of user account for authentication.
 - `MYSQL_USER`: Username used for authentication,
@@ -158,6 +158,8 @@ Twitter [@moov_io](https://twitter.com/moov_io)	| You can follow Moov.IO's Twitt
 
 Yes please! Please review our [Contributing guide](CONTRIBUTING.md) and [Code of Conduct](https://github.com/moov-io/ach/blob/master/CODE_OF_CONDUCT.md) to get started!
 
+Paygate includes several "long" tests which spawn Docker containers, make requests over the internet, and perform more complicated tests. To skip these long tests add the `-short` flag to `go test`.
+
 Note: This project uses Go Modules, which requires Go 1.11 or higher, but we ship the vendor directory in our repository.
 
 ### Test Coverage

common.go

@@ -166,23 +166,6 @@ func (a *Amount) UnmarshalJSON(b []byte) error {
 	return a.FromString(s)
 }
 
-var errTimeout = errors.New("timeout exceeded")
-
-// try will attempt to call f, but only for as long as t. If the function is still
-// processing after t has elapsed then errTimeout will be returned.
-func try(f func() error, t time.Duration) error {
-	answer := make(chan error)
-	go func() {
-		answer <- f()
-	}()
-	select {
-	case err := <-answer:
-		return err
-	case <-time.After(t):
-		return errTimeout
-	}
-}
-
 // startOfDayAndTomorrow returns two time.Time values from a given time.Time value.
 // The first is at the start of the same day as provided and the second is exactly 24 hours
 // after the first.

common_test.go

@@ -171,28 +171,6 @@ func TestAmount__json(t *testing.T) {
 	}
 }
 
-func TestTry(t *testing.T) {
-	start := time.Now()
-
-	err := try(func() error {
-		time.Sleep(50 * time.Millisecond)
-		return nil
-	}, 1*time.Second)
-
-	if err != nil {
-		t.Fatal(err)
-	}
-
-	diff := time.Since(start)
-
-	if diff < 50*time.Millisecond {
-		t.Errorf("%v was under 50ms", diff)
-	}
-	if limit := 2 * 100 * time.Millisecond; diff > limit {
-		t.Errorf("%v was over %v", diff, limit)
-	}
-}
-
 func TestStartOfDayAndTomorrow(t *testing.T) {
 	now := time.Now()
 	min, max := startOfDayAndTomorrow(now)