fix: change inner req hdr caused race (#782)

#775 doesn't really fix the problem. Since we already create the wrapper, we should pass the wrapper directly to OnLog, instead of setting the reqHdr field. Signed-off-by: spacewander <[email protected]>
mosn · Oct 28, 2024 · e0c9ce2 · e0c9ce2
1 parent f5e0d14
commit e0c9ce2
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/api/pkg/filtermanager/filtermanager_dev.go b/api/pkg/filtermanager/filtermanager_dev.go
@@ -32,10 +32,7 @@ func (m *filterManager) OnLog(reqHdr capi.RequestHeaderMap, reqTrailer capi.Requ
 	wrappedReqHdr := &filterManagerRequestHeaderMap{
 		RequestHeaderMap: reqHdr,
 	}
-	m.hdrLock.Lock()
-	m.reqHdr = wrappedReqHdr
-	m.hdrLock.Unlock()
-	m.runOnLogPhase(m.reqHdr, reqTrailer, rspHdr, rspTrailer)
+	m.runOnLogPhase(wrappedReqHdr, reqTrailer, rspHdr, rspTrailer)
 }
 
 func wrapFilterManager(fm *filterManager) capi.StreamFilter {