Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make tests pass #32

Merged
merged 6 commits into from
Jan 31, 2024
Merged

fix: make tests pass #32

merged 6 commits into from
Jan 31, 2024

Conversation

arnaugomez
Copy link
Contributor

@arnaugomez arnaugomez commented Jan 25, 2024

Connection with issue(s)

Resolve issue #31

Testing and Review Notes

Run tests

Screenshots or Videos

image

To Do

  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • request the "UX" team perform a design review (if/when applicable)

@arnaugomez arnaugomez requested a review from hazzo January 25, 2024 13:51
@arnaugomez arnaugomez self-assigned this Jan 25, 2024
@arnaugomez
Copy link
Contributor Author

Depending on the order of the tests, sometimes they pass and sometimes they fail.
For example, with this seed they fail:

fvm flutter test --test-randomize-ordering-seed=3030271670

@arnaugomez
Copy link
Contributor Author

arnaugomez commented Jan 29, 2024

At last I solved it! It took ages to find the bug

@arnaugomez
Copy link
Contributor Author

arnaugomez commented Jan 29, 2024

I solved it by resetting the GoRouter between tests:

  setUp(() {
    getIt<GoRouter>().go('/home');
  });

@hazzo hazzo merged commit 7104dda into master Jan 31, 2024
1 check passed
@hazzo hazzo deleted the fix/#31-tests-fail branch January 31, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants