Skip to content

refactor child contracts #8

refactor child contracts

refactor child contracts #8

Triggered via pull request October 10, 2023 10:45
Status Failure
Total duration 2m 9s
Artifacts

actions.yml

on: pull_request
Contracts  /  Wasm tests
1m 57s
Contracts / Wasm tests
Contracts  /  Rust tests
29s
Contracts / Rust tests
Contracts  /  Clippy linter check
34s
Contracts / Clippy linter check
Fit to window
Zoom out
Zoom in

Annotations

13 errors and 2 warnings
[clippy] multi-transfer-esdt/src/lib.rs#L133: multi-transfer-esdt/src/lib.rs#L133
error: this `if` has identical blocks --> multi-transfer-esdt/src/lib.rs:133:92 | 133 | if !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftCreate) { | ____________________________________________________________________________________________^ 134 | | self.transfer_failed_invalid_token(batch_id, tx_nonce); 135 | | 136 | | return true; 137 | | } else if token.amount > NFT_AMOUNT | |_____________^ | note: same as this --> multi-transfer-esdt/src/lib.rs:139:13 | 139 | / { 140 | | self.transfer_failed_invalid_token(batch_id, tx_nonce); 141 | | 142 | | return true; 143 | | } | |_____________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `#[deny(clippy::if_same_then_else)]` on by default
Contracts / Rust tests: multisig/src/action.rs#L4
unresolved import `transaction::EthTransaction`
Contracts / Rust tests: multisig/src/util.rs#L3
unresolved imports `transaction::EthTransaction`, `transaction::EthTxAsMultiValue`
Contracts / Rust tests: multisig/src/lib.rs#L13
unresolved imports `token_module::AddressPercentagePair`, `token_module::INVALID_PERCENTAGE_SUM_OVER_ERR_MSG`, `token_module::PERCENTAGE_TOTAL`
Contracts / Rust tests: multisig/src/setup.rs#L4
unresolved import `eth_address`
Contracts / Rust tests: multisig/src/setup.rs#L6
unresolved import `fee_estimator_module`
Contracts / Rust tests: multisig/src/storage.rs#L4
unresolved import `eth_address`
Contracts / Rust tests: multisig/src/queries.rs#L51
cannot find type `EthTxAsMultiValue` in this scope
Contracts / Rust tests: multisig/src/queries.rs#L65
cannot find type `EthTxAsMultiValue` in this scope
Contracts / Rust tests: multisig/src/queries.rs#L9
cannot find type `EthTxAsMultiValue` in this scope
Contracts / Rust tests: multisig/src/lib.rs#L225
cannot find type `EthTxAsMultiValue` in this scope
Contracts / Wasm tests
failed to evaluate generic const expression
Contracts / Wasm tests
Process completed with exit code 101.
[clippy] multi-transfer-esdt/src/lib.rs#L132: multi-transfer-esdt/src/lib.rs#L132
warning: this `else { if .. }` block can be collapsed --> multi-transfer-esdt/src/lib.rs:132:16 | 132 | } else { | ________________^ 133 | | if !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftCreate) { 134 | | self.transfer_failed_invalid_token(batch_id, tx_nonce); 135 | | ... | 143 | | } 144 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 132 ~ } else if !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftCreate) { 133 + self.transfer_failed_invalid_token(batch_id, tx_nonce); 134 + 135 + return true; 136 + } else if token.amount > NFT_AMOUNT 137 + && !self.is_local_role_set(&token.token_identifier, &EsdtLocalRole::NftAddQuantity) 138 + { 139 + self.transfer_failed_invalid_token(batch_id, tx_nonce); 140 + 141 + return true; 142 + } |
Contracts / Rust tests: multisig/src/lib.rs#L21
unused import: `token_module::ProxyTrait as _`