feat(iroh-net)!: upgrade to Quinn 0.11 and Rustls 0.23 #2595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some warnings still nead that treatment
The stream could have been stopped by the remote but still has the same effect. So this isn't expected to be an error
endpoint_bidi_send_recv might be flaky, not sure yet
This adds a bunch of anyhow .context() calls so that users get much nicer errors instead of something rather cryptic
We really must keep using this till the last possible moment. This API is no longer public so we can make it use QuicMappedAddr.
We need to sure that triggering these odd conditions will not kill our entire magicsocket
Also make it easier to locally reproduce CI failures around this.
This gives an error as used before.
We had two paths that handled not sending a transmit at all. This meant the 2nd path was never triggered. This instead removes the early-returns making it easier to reason about the paths taken. Now only an error is logged if there was nothing sent. --------- Co-authored-by: Philipp Krüger <[email protected]>
|
don't we need a |
flub
changed the title
matheus23
reviewed
Aug 28, 2024
1 task
Co-authored-by: Philipp Krüger <[email protected]>
Co-authored-by: Philipp Krüger <[email protected]>
1 task
matheus23
approved these changes
Aug 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
## Description Since we have made MagicSock private it should always be created via the Endpoint, unless we are internally messing around with tests or so. Because of this we can make sure that the Endpoint always attaches the correct "me" field to the span. Reducing the amount of noise in the default log output. ## Breaking Changes None ## Notes & open questions Please do not merge before #2595 is merged. I'm trying to not add any further changes to that PR. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - ~~[ ] All breaking changes documented.~~
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
## Description iroh-gossip has a direct dependency on Quinn but does not need it. Remove this. ## Breaking Changes none ## Notes & open questions Please do not merge before #2595 is merged. I'm trying to not modify that PR any further. ## Change checklist - [x] Self-review. - ~~[ ] Documentation updates following the [style guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text), if relevant.~~ - ~~[ ] Tests if relevant.~~ - ~~[ ] All breaking changes documented.~~
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades the Quinn and Rustls dependencies. This touches a lot of dependencies and affects a lot of the internal API due to the changes in Quinn.
Breaking Changes
iroh::net::endpoint::Endpoint::acceptnow returnsIncominginstead ofConnecting. This allows rejecting incoming connections earlier, notify the initiating side to retry later and more. To get backConnecting, simply useIncoming::accept(). If all you did withConnectingbefore was to.awaitit, you can do the same withIncoming, too, and get back aConnection.iroh::net::endpoint::Builder::concurrent_connections. The amount of concurrent connections is now controlled by either callingIncoming::acceptorIncoming::refuseafterEndpoint::accept.Notes & open questions
See #2273 for the tracking issue coordinating all this work. This is the last piece of the puzzle.
Change checklist