Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iroh-net)!: upgrade to Quinn 0.11 and Rustls 0.23 #2595

Merged
merged 96 commits into from
Aug 28, 2024
Merged

feat(iroh-net)!: upgrade to Quinn 0.11 and Rustls 0.23 #2595

merged 96 commits into from
Aug 28, 2024

Commits on Mar 19, 2024

  1. Move to quinn 0.11

    @flub
    flub committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    ac4d0f8 View commit details
    Browse the repository at this point in the history

  2. make this work non-local

    @flub
    flub committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    55f03f2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into flub/quinn11

    @flub
    flub committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    af2f448 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Update to newer commit

    @flub
    flub committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    b6583ca View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into flub/quinn11

    @flub
    flub committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    c0ba1c3 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into flub/quinn11

    @flub
    flub committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    83df726 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2024

  1. Merge remote-tracking branch 'origin/main' into dig/quinn11

    @dignifiedquire
    dignifiedquire committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    fbe1c0a View commit details
    Browse the repository at this point in the history

  2. basic pass at upgrading to [email protected]

    @dignifiedquire
    dignifiedquire committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    90c1327 View commit details
    Browse the repository at this point in the history

  3. fixups

    @dignifiedquire
    dignifiedquire committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    933d1b5 View commit details
    Browse the repository at this point in the history

  4. more tls configs

    @dignifiedquire
    dignifiedquire committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1a89091 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge remote-tracking branch 'origin/main' into dig/quinn11

    @dignifiedquire
    dignifiedquire committed May 8, 2024
    Configuration menu
    Copy the full SHA
    d344e33 View commit details
    Browse the repository at this point in the history

  2. fixup compiles

    @dignifiedquire
    dignifiedquire committed May 8, 2024
    Configuration menu
    Copy the full SHA
    c8af7cb View commit details
    Browse the repository at this point in the history

  3. upgrade iroh-dns-server

    @dignifiedquire
    dignifiedquire committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7c13182 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. rustls 0.23 all the deps and all the errors 

    some warnings still nead that treatment
    @flub
    flub committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    125e3b5 View commit details
    Browse the repository at this point in the history

  2. this seems to work now

    @flub
    flub committed Jun 12, 2024
    Configuration menu
    Copy the full SHA
    649e215 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch 'main' into dig/quinn11 - probably broken

    @flub
    flub committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0754255 View commit details
    Browse the repository at this point in the history

  2. firt set of fixes, but we need iroh-quinn

    @flub
    flub committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7f4a8e3 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. get a lot closer to compiling it all

    @flub
    flub committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    82fd3ff View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. it compiles

    @flub
    flub committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    631b448 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dig/quinn11

    @flub
    flub committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    acdd744 View commit details
    Browse the repository at this point in the history

  3. fix the magicsock tests, we need to wait for stopped now

    @flub
    flub committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    fabbf4e View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Merge branch 'main' into dig/quinn11

    @flub
    flub committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    9e7909c View commit details
    Browse the repository at this point in the history

  2. some clippy cleanup

    @flub
    flub committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    0e081f5 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Merge branch 'main' into dig/quinn11

    @flub
    flub committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    205a385 View commit details
    Browse the repository at this point in the history

  2. Use an explicit cryptoprovider

    @flub
    flub committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    ecb57b4 View commit details
    Browse the repository at this point in the history

  3. Use stopped to ensure the remove receives things

    @flub
    flub committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    71e6d2a View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. finish is not supposed to return an error now 

    The stream could have been stopped by the remote but still has the
same effect.  So this isn't expected to be an error
    @flub
    flub committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    5af4005 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dig/quinn11

    @flub
    flub committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    74260b3 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. philipp's fix

    @flub
    flub committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    a7e0b1b View commit details
    Browse the repository at this point in the history

  2. Improve logging a bit, fix a few more tests 

    endpoint_bidi_send_recv might be flaky, not sure yet
    @flub
    flub committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    e103b2f View commit details
    Browse the repository at this point in the history

  3. Better closing of connection

    @flub
    flub committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    7997778 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. fix(iroh-net): Make the test endpoint for discovery tests actually ac… 

    …cept hanshakes
    @matheus23
    matheus23 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    97f43d2 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dig/quinn11

    @flub
    flub committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9f4c0fd View commit details
    Browse the repository at this point in the history

  3. Better expect messages

    @flub
    flub committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    60d1eb1 View commit details
    Browse the repository at this point in the history

  4. Use released axum-server instead of branch/patch

    @matheus23
    matheus23 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    6b22f42 View commit details
    Browse the repository at this point in the history

  5. fix: also run send_stream.stopped().await after send_stream.finish()

    @matheus23
    matheus23 committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    5bb472e View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Merge branch 'main' into dig/quinn11

    @matheus23
    matheus23 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    7154a54 View commit details
    Browse the repository at this point in the history

  2. Fix perf: Implement max_transmit_segments and more in AsyncUdpSocket

    @matheus23
    matheus23 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1700565 View commit details
    Browse the repository at this point in the history

  3. fix: Use std::cmp::min, not max

    @matheus23
    matheus23 committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    56d4938 View commit details
    Browse the repository at this point in the history

  4. Deny all of aws-lc

    @flub
    flub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0545a47 View commit details
    Browse the repository at this point in the history

  5. remove unsued dep

    @flub
    flub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    f217b54 View commit details
    Browse the repository at this point in the history

  6. Get onto a single version of pkarr

    @flub
    flub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    0307964 View commit details
    Browse the repository at this point in the history

  7. Bump rustls-webpki direct dep 

    Now we only have hickory-resolver depending on an old one
    @flub
    flub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d29201e View commit details
    Browse the repository at this point in the history

  8. bump request. this now depends on rustls 0.23 at least

    @flub
    flub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    9289c27 View commit details
    Browse the repository at this point in the history

  9. Maybe make axum-server not depend on aws-lc? no clue

    @flub
    flub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    ed3b56c View commit details
    Browse the repository at this point in the history

  10. And finally get rid of aws-ls-*

    @flub
    flub committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1f30b35 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2024

  1. update iroh-quinn

    @flub
    flub committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    dc40e67 View commit details
    Browse the repository at this point in the history

  2. update quic-rpc

    @flub
    flub committed Aug 7, 2024
    Configuration menu
    Copy the full SHA
    1f1a12f View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. fix(iroh-net): Fix cert resolver with rustls version 0.23.11 and above. 

    Upstream PR: libp2p/rust-libp2p#5498
    @matheus23
    matheus23 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    d5b92c1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dig/quinn11

    @matheus23
    matheus23 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    144181b View commit details
    Browse the repository at this point in the history

  3. test windows CI ... :(

    @matheus23
    matheus23 committed Aug 12, 2024
    Configuration menu
    Copy the full SHA
    b6b0ba9 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Revert "test windows CI ... :(" 

    This reverts commit b6b0ba9.
    @matheus23
    matheus23 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    ea999fc View commit details
    Browse the repository at this point in the history

  2. test: Turn off DNS discovery in tests

    @matheus23
    matheus23 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2898f65 View commit details
    Browse the repository at this point in the history

  3. fix: warnings

    @matheus23
    matheus23 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    35d3419 View commit details
    Browse the repository at this point in the history

  4. Revert "fix: warnings" 

    This reverts commit 35d3419.
    @matheus23
    matheus23 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fb7fad3 View commit details
    Browse the repository at this point in the history

  5. Revert "test: Turn off DNS discovery in tests" 

    This reverts commit 2898f65.
    @matheus23
    matheus23 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a8d3730 View commit details
    Browse the repository at this point in the history

  6. setup logging in provider tests

    @matheus23
    matheus23 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    d3ec04b View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. fix: Don't return unspecified IP addrs in normalized_local_addr

    @matheus23
    matheus23 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    e00a81d View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Make windows always use dst_ip: None

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    48120b7 View commit details
    Browse the repository at this point in the history

  2. fix import

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    62f5a64 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into dig/quinn11

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6ec1169 View commit details
    Browse the repository at this point in the history

  4. allow normalized_local_addr to be unused on windows

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b0cba0a View commit details
    Browse the repository at this point in the history

  5. Depend on released tokio-rustls-acme

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    9b12753 View commit details
    Browse the repository at this point in the history

  6. update to new iroh-quinn

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6d27e11 View commit details
    Browse the repository at this point in the history

  7. Some comments explaining the reasoning for dst_ip: None

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    92bc031 View commit details
    Browse the repository at this point in the history

  8. Update to hickory alpha to remove old rustls dep

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    650d254 View commit details
    Browse the repository at this point in the history

  9. switch to new quic-rpc branch

    @dignifiedquire
    dignifiedquire committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    27710a8 View commit details
    Browse the repository at this point in the history

  10. Depend on released iroh-quinn & quic-rpc

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    d2545db View commit details
    Browse the repository at this point in the history

  11. Merge branch 'main' into dig/quinn11

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    5b41dd0 View commit details
    Browse the repository at this point in the history

  12. bump bytes

    @dignifiedquire
    dignifiedquire committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    efb2822 View commit details
    Browse the repository at this point in the history

  13. try older revision again

    @matheus23
    matheus23 committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    76d3349 View commit details
    Browse the repository at this point in the history

  14. Merge branch 'main' into dig/quinn11

    @dignifiedquire
    dignifiedquire authored Aug 15, 2024
    Configuration menu
    Copy the full SHA
    b5aae3c View commit details
    Browse the repository at this point in the history

  15. revert to released quinn

    @dignifiedquire
    dignifiedquire committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    aba33fb View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. Remove dependency on rustls v0.22.4

    @matheus23
    matheus23 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    c078dc3 View commit details
    Browse the repository at this point in the history

  2. Update some pkgs to remove duplicate deps

    @matheus23
    matheus23 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    474f9c2 View commit details
    Browse the repository at this point in the history

  3. remove unused quinn dependency

    @matheus23
    matheus23 committed Aug 16, 2024
    Configuration menu
    Copy the full SHA
    e32f108 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Merge branch 'main' into dig/quinn11

    @matheus23
    matheus23 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    0790602 View commit details
    Browse the repository at this point in the history

  2. Skip errors from Incoming::accept

    @matheus23
    matheus23 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    6c11420 View commit details
    Browse the repository at this point in the history

  3. Try to minimize Cargo.lock changes

    @matheus23
    matheus23 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    d1ab583 View commit details
    Browse the repository at this point in the history

  4. Update TODOs and use cmp::max for max_transmit_segments

    @matheus23
    matheus23 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    715e263 View commit details
    Browse the repository at this point in the history

  5. cleanup TODOs, reduce diff

    @matheus23
    matheus23 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    f0257e1 View commit details
    Browse the repository at this point in the history

  6. avoid span.enter() in async

    @matheus23
    matheus23 committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    9cbc412 View commit details
    Browse the repository at this point in the history

  7. Improve error messages 

    This adds a bunch of anyhow .context() calls so that users get much
nicer errors instead of something rather cryptic
    @flub
    flub committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    2227225 View commit details
    Browse the repository at this point in the history

  8. Use QuicMappedAddr when we're dealing with this 

    We really must keep using this till the last possible moment.  This
API is no longer public so we can make it use QuicMappedAddr.
    @flub
    flub committed Aug 22, 2024
    Configuration menu
    Copy the full SHA
    c0a9a45 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Test odd paths of try_send 

    We need to sure that triggering these odd conditions will not kill our entire magicsocket
    @flub
    flub authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    cbb3ca0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dig/quinn11

    @flub
    flub committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    4ca4392 View commit details
    Browse the repository at this point in the history

  3. Fixup internal dep that regressed 

    Also make it easier to locally reproduce CI failures around this.
    @flub
    flub committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    eb216c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Correctly close the connection in the example 

    This gives an error as used before.
    @flub
    flub committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    23b1f90 View commit details
    Browse the repository at this point in the history

  2. some span wording improvements

    @flub
    flub committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    873bfb8 View commit details
    Browse the repository at this point in the history

  3. improve docs

    @flub
    flub committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f28bd27 View commit details
    Browse the repository at this point in the history

  4. fix some spelling errors and add TODOs

    @flub
    flub committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    c853d38 View commit details
    Browse the repository at this point in the history

  5. Simplify handling of no sending (#2677) 

    We had two paths that handled not sending a transmit at all. This meant
the 2nd path was never triggered. This instead removes the early-returns
making it easier to reason about the paths taken. Now only an error is
logged if there was nothing sent.

---------

Co-authored-by: Philipp Krüger <[email protected]>
    @flub @matheus23
    flub and matheus23 authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a194fdb View commit details
    Browse the repository at this point in the history

  6. better expect message

    @flub
    flub committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    81ce766 View commit details
    Browse the repository at this point in the history

  7. use the min of max_transmit_segments 

    Co-authored-by: Philipp Krüger <[email protected]>
    @flub @matheus23
    flub and matheus23 authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    ae51694 View commit details
    Browse the repository at this point in the history

  8. max max_reive_segments 

    Co-authored-by: Philipp Krüger <[email protected]>
    @flub @matheus23
    flub and matheus23 authored Aug 28, 2024
    Configuration menu
    Copy the full SHA
    3fb5624 View commit details
    Browse the repository at this point in the history

  9. update comment

    @flub
    flub committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    5052c20 View commit details
    Browse the repository at this point in the history