Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest wrapper should return None, not result #2120

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
pytest wrapper should return None, not result
While the wrapper does need the output of the wrapped function for
processing, pytest complains for any test function that returns data.

Updates the wrapper function that processes mocked data to not return
the wrapped function result.

Closes #2118
bewing committed Jul 26, 2024
commit 39c50fbf7e2187c4714c51e3b18eb73688ee377c
2 changes: 1 addition & 1 deletion napalm/base/test/getters.py
Original file line number Diff line number Diff line change
@@ -90,7 +90,7 @@ def mock_wrapper(cls, test_case):
attr.current_test = "" # Empty them to avoid side effects
attr.current_test_case = "" # Empty them to avoid side effects

return result
return None

@functools.wraps(func)
def real_wrapper(cls, test_case):