Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest wrapper should return None, not result #2120

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

pytest wrapper should return None, not result #2120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39c50fb
pytest wrapper should return None, not result
bewing Jul 16, 2024
24c8d1e
remove invalid pytest flags
bewing Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion napalm/base/test/getters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def mock_wrapper(cls, test_case):
attr.current_test = "" # Empty them to avoid side effects
attr.current_test_case = "" # Empty them to avoid side effects

return result
return None

@functools.wraps(func)
def real_wrapper(cls, test_case):
Expand Down
2 changes: 0 additions & 2 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ python_files =
test_*.py
*_test.py
tests.py
json_report = report.json
jsonapi = true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were these two changes meant to be included in this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because pytest complained/printed warnings when they were present:

https://github.com/napalm-automation/napalm/actions/runs/9962394420/job/27526038035#step:8:729

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I believe we pass these as command line options in the docs build: https://github.com/napalm-automation/napalm/blob/develop/docs/test.sh#L8


[coverage:run]
include =
Expand Down