Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pekern
force-pushed
the
feature/løsner-validering
branch
from
63dee1e to
e8005cf
Compare
jolarsen
reviewed
Apr 26, 2024
| @@ -75,7 +75,7 @@ private static void verifiserOpprettetAndel(BeregningsgrunnlagPrStatusOgAndelDto | |||
| Objects.requireNonNull(andel.getBeregningsperiodeFom(), "BeregningsperiodeFom " + andel); | |||
| Objects.requireNonNull(andel.getBeregningsperiodeTom(), "BeregningsperiodeTom " + andel); | |||
| } | |||
| if (andel.getBgAndelArbeidsforhold().isPresent()) { | |||
| if (andel.getBgAndelArbeidsforhold().isPresent() && andel.getKilde().equals(AndelKilde.PROSESS_START)) { | |||
There was a problem hiding this comment.
Kan ikke andel.getKilde() gi deg null her - ref sjekk i forrige if ?
There was a problem hiding this comment.
Kilde er aldri null, så hadde ikke trengt sjekken over. men har diskutert med Espen og vi prøver heller å fjerne så mye som mulig av arbeidsperiode istedenfor. Kommer i ny PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.