Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/løsner validering #496

Closed
wants to merge 1 commit into from
Closed

Feature/løsner validering #496

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...r/src/main/java/no/nav/folketrygdloven/kalkulator/steg/BeregningsgrunnlagVerifiserer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ private static void verifiserOpprettetAndel(BeregningsgrunnlagPrStatusOgAndelDto
Objects.requireNonNull(andel.getBeregningsperiodeFom(), "BeregningsperiodeFom " + andel);
Objects.requireNonNull(andel.getBeregningsperiodeTom(), "BeregningsperiodeTom " + andel);
}
if (andel.getBgAndelArbeidsforhold().isPresent()) {
if (andel.getBgAndelArbeidsforhold().isPresent() && andel.getKilde().equals(AndelKilde.PROSESS_START)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kan ikke andel.getKilde() gi deg null her - ref sjekk i forrige if ?

Copy link
Contributor Author

@pekern pekern Apr 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kilde er aldri null, så hadde ikke trengt sjekken over. men har diskutert med Espen og vi prøver heller å fjerne så mye som mulig av arbeidsperiode istedenfor. Kommer i ny PR

BGAndelArbeidsforholdDto arbFor = andel.getBgAndelArbeidsforhold().get();
Objects.requireNonNull(arbFor.getArbeidsperiodeFom(), "arbeidsperiodeFom " + andel);
Objects.requireNonNull(arbFor.getArbeidsperiodeTom(), "arbeidsperiodeTom " + andel);
Expand Down