-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop ndk-glue
dependency from the main crate
#50
Conversation
Commit d42d201 ("Update Android dependencies and example.") correctly replaces `ndk-glue` with `ndk-context` as a more generic crate to hold on to a global `JavaVM` and Android `jobject` `Context`, but didn't drop the unused `ndk-glue` crate from the list of Android dependencies. This crate is only used in the example crate, and [shouldn't clobber downstream crates]. Besides, `ndk-glue` has been deprecated for some time and should be replaced by `android-activity` in the example in a followup PR. [shouldn't clobber downstream crates]: https://github.com/emilk/egui/pull/3606/files#r1401313794
In hindsight, while looking into this project, it seems to rely on some complicated interplay between Android's In fact:
|
Awesome, if you can pull all that off, I'd be very appreciative. I'd love to see Android support improved but I'm so far behind on maintaining this project that it hasn't been a priority. FWIW I've made attempts at this in the past and gave up partway along the way, but if you can improve it and verify that it works, that'd be great. I'd love to try mobile game development with TTS support on Android. |
Sounds good; perhaps we can already get this PR in and I'll think about taking a look. In my mind there are essentially two ways to develop Android apps with Rust:
This example app, from what I understand, appears to try both. I think we'd address the elephant in the room by moving to an explicit That'd clean up the support for purely native apps with a minimal example, if we figure out how to cleanly embed the Likewise, for non- For now I'm not even sure how the example app is intended to be built, since a |
@ndarilek is this something you might still want to merge? I won't have any time in the coming months to look into improving Android support for this project, but the PR/fix is valid as proposed and solves a real "issue" out in the wild. We can always reference one of these replies in a new issue to keep track of ideas for future improvements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for the delay in merging this--I'm trying to get back on top of managing my open source projects after starting a new job a while back and not having a lot of energy for coding after work.
Commit d42d201 ("Update Android dependencies and example.") correctly replaces
ndk-glue
withndk-context
as a more generic crate to hold on to a globalJavaVM
and Androidjobject
Context
, but didn't drop the unusedndk-glue
crate from the list of Android dependencies. This crate is only used in the example crate, and shouldn't clobber downstream crates.Besides,
ndk-glue
has been deprecated for some time and should be replaced byandroid-activity
in the example in a followup PR.