Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop ndk-glue dependency from the main crate #50

Merged
merged 1 commit into from
Feb 9, 2024

Commits on Nov 21, 2023

  1. Drop ndk-glue dependency from the main crate

    Commit d42d201 ("Update Android dependencies and example.") correctly
    replaces `ndk-glue` with `ndk-context` as a more generic crate to hold on
    to a global `JavaVM` and Android `jobject` `Context`, but didn't drop the
    unused `ndk-glue` crate from the list of Android dependencies.  This
    crate is only used in the example crate, and [shouldn't clobber
    downstream crates].
    
    Besides, `ndk-glue` has been deprecated for some time and should be
    replaced by `android-activity` in the example in a followup PR.
    
    [shouldn't clobber downstream crates]: https://github.com/emilk/egui/pull/3606/files#r1401313794
    MarijnS95 committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    2a81dc9 View commit details
    Browse the repository at this point in the history